RESOLVED CONFIGURATION CHANGED 115773
Fix button baseline calculations for Mac with dynamic changes 
https://bugs.webkit.org/show_bug.cgi?id=115773
Summary Fix button baseline calculations for Mac with dynamic changes
Ryosuke Niwa
Reported 2013-05-07 19:48:01 PDT
We should consider merging https://chromium.googlesource.com/chromium/blink/+/b190272191c3c584f312f6ea17fec039ef5bb77f Fix button baseline calculations for Mac with dynamic changes Also convert a button test to a reftest and add a new button test. The new test is to test baselines, which is useful because in the past I have relied on button-generated-content to verify baseline behavior. The conversion to a reftest is what found the bug that I fixed in RenderButton.cpp -- the button would otherwise be positioned wrong after the dynamic changes.
Attachments
Add attachment proposed patch, testcase, etc.
Ahmad Saleem
Comment 1 2022-08-22 13:51:20 PDT
I changed the test case from Chromium patch into JSFiddle: Link - https://jsfiddle.net/suwkj4av/show Safari 15.6.1 and STP 151 still fail the test at least two cases. I am happy to work on it, if it is not super weird and someone can guide. Just wanted to update. Thanks!
Radar WebKit Bug Importer
Comment 2 2022-08-23 16:00:33 PDT
<rdar://problem/99055604>
Ahmad Saleem
Comment 3 2022-12-17 13:53:53 PST
I used ahem.js in the testcase from Comment 01 and now Safari Technology Preview 160 is now passing all cases: Link - https://jsfiddle.net/r8yt1z9f/show I am marking this as "RESOLVED CONFIGURATION CHANGED". Thanks!
Note You need to log in before you can comment on or make changes to this bug.