WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
115770
Remove unused method and de-virtualize others in Element.h
https://bugs.webkit.org/show_bug.cgi?id=115770
Summary
Remove unused method and de-virtualize others in Element.h
Ryosuke Niwa
Reported
2013-05-07 19:33:12 PDT
Merge
https://chromium.googlesource.com/chromium/blink/+/c2c2ff9cb69f46f5cc9d289b2bfbdb8ab5bd3e49
The de-virtualization possibilities were noted whilst "FINALizing" the Node hierarchy. If a method is successfully marked FINAL but then fails when marked OVERRIDE as well, the method by definition does not need to be virtual.
Attachments
Cleanup
(2.53 KB, patch)
2013-05-07 19:34 PDT
,
Ryosuke Niwa
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1
2013-05-07 19:34:20 PDT
Created
attachment 201017
[details]
Cleanup
WebKit Commit Bot
Comment 2
2013-05-08 00:57:31 PDT
Comment on
attachment 201017
[details]
Cleanup Clearing flags on attachment: 201017 Committed
r149718
: <
http://trac.webkit.org/changeset/149718
>
WebKit Commit Bot
Comment 3
2013-05-08 00:57:34 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug