Bug 115768 - Store the quotes in the same allocation as the QuotesData object
Summary: Store the quotes in the same allocation as the QuotesData object
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-07 16:32 PDT by Anders Carlsson
Modified: 2013-05-08 00:06 PDT (History)
4 users (show)

See Also:

Attachments
Patch (5.36 KB, patch)
2013-05-07 16:35 PDT, Anders Carlsson 		kling: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2013-05-07 16:32:26 PDT 
Store the quotes in the same allocation as the QuotesData object
Comment 1 Anders Carlsson 2013-05-07 16:35:18 PDT 
Created attachment 200992 [details]
Patch
Comment 2 Andreas Kling 2013-05-07 16:52:30 PDT 
Comment on attachment 200992 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=200992&action=review

r=me!!!

> Source/WebCore/rendering/style/QuotesData.h:35
> +#if COMPILER(MSVC)
> +#pragma warning(push)
> +#pragma warning(disable: 4200) // Disable "zero-sized array in struct/union" warning
> +#endif

Maybe we should just do this globally.

> Source/WebCore/rendering/style/QuotesData.h:51
> +    unsigned m_numQuotes;

m_numFoo doesn't sound very WebKitty. How about m_quoteCount?
Comment 3 Anders Carlsson 2013-05-07 18:47:09 PDT 
Committed r149707: <http://trac.webkit.org/changeset/149707>
Comment 4 Darin Adler 2013-05-08 00:06:35 PDT 
Anders, I have a fix for the regression here in my upcoming patch.