Fix memory leak after r149692

[Alex Christensen]

https://bugs.webkit.org/show_bug.cgi?id=42324 introduced a memory leak.  I fixed this leak by using RetainPtr<WKDataRef> instead of just WKDataRef.  I also added UNUSED_PARAM macros for non-cf builds.

[Alex Christensen]

Created attachment 200981 [details]
Patch

[Tim Horton]

Comment on attachment 200981 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=200981&action=review

> Tools/ChangeLog:3
> +        fixed a memory leak introduced by bug 42324 by using a RetainPtr

Probably should have been capitalized and probably reference the revision and not the bug.

[WebKit Commit Bot]

Comment on attachment 200981 [details]
Patch

Clearing flags on attachment: 200981

Committed r149697: <http://trac.webkit.org/changeset/149697>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Darin Adler]

Comment on attachment 200981 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=200981&action=review

> Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:848
> +    RetainPtr<WKDataRef> wkData = WKBundleFrameCopyWebArchive(frame);

This doesn’t fix the leak. You need to call adoptCF to fix the leak.

[Mark Rowe (bdash)]

It was fixed properly under bug 115766.