Bug 115758 – Support -webkit-system-font on OS X

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Enrica Casucci]

We want to add a custom font family name to allow developers to reference the system UI font on OS X.

<rdar://problem/13433854>

[Enrica Casucci]

Created attachment 200973 [details]
Patch

[WebKit Commit Bot]

Attachment 200973 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/platform/mac/fast/text/systemFont.html', u'LayoutTests/platform/mac/platform/mac/fast/text/systemFont-expected.png', u'LayoutTests/platform/mac/platform/mac/fast/text/systemFont-expected.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/platform/mac/WebFontCache.mm']" exit_code: 1
LayoutTests/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Source/WebCore/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 2 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Enrica Casucci]

I've updated the ChangeLog with the bug number, fixing the style issue.

[Ryosuke Niwa]

Comment on attachment 200973 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=200973&action=review

> LayoutTests/ChangeLog:9
> +        * platform/mac/platform/mac/fast/text/systemFont-expected.png: Added.

You need to set svnprop.

[Dean Jackson]

Comment on attachment 200973 [details]
Patch

r+ with changes required by svn and ChangeLog

[Enrica Casucci]

Committed revision 149698.