Bug 11575 - REGRESSION: WebCore crash in CSSParser/HTMLTokenizer
Summary: REGRESSION: WebCore crash in CSSParser/HTMLTokenizer
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P1 Normal
Assignee: Nobody
URL: http://www.nature.com/news/2006/06110...
Keywords: NeedsReduction, Regression
Depends on:
Reported: 2006-11-11 20:39 PST by Matt Lilek
Modified: 2006-11-14 11:06 PST (History)
3 users (show)

See Also:

crash log (21.62 KB, text/plain)
2006-11-11 20:40 PST, Matt Lilek
no flags Details
Crash fix (1.35 KB, patch)
2006-11-12 10:44 PST, Rob Buis
darin: review+
Details | Formatted Diff | Diff
Test case (2.36 KB, application/octet-stream)
2006-11-14 09:28 PST, mitz
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Lilek 2006-11-11 20:39:39 PST
Loading URL causes crash on r17739.  The window title updates properly, but after that it beachballs then crashes.
Comment 1 Matt Lilek 2006-11-11 20:40:32 PST
Created attachment 11488 [details]
crash log
Comment 2 Matt Lilek 2006-11-11 20:55:34 PST
Regressed between r17722 and r17739 (probably r17730).
Comment 3 David Kilzer (:ddkilzer) 2006-11-11 20:57:43 PST
Probably related to Bug 10893.  Do nightlies before r17730 work without crashing?

Comment 4 Rob Buis 2006-11-12 10:44:37 PST
Created attachment 11500 [details]
Crash fix

I assumed the check was not needed, seeing that all tests passed, but it seems I was wrong. This patch
does check for null and now the page works fine.

Comment 5 mitz 2006-11-12 11:12:12 PST
Comment on attachment 11500 [details]
Crash fix

This needs a layout test.
Comment 6 Darin Adler 2006-11-13 10:55:11 PST
Comment on attachment 11500 [details]
Crash fix

Is there a way we can make a layout test for this? I'd prefer to have a regression test so that we don't make this mistake again in the future.

r=me on the change, but I'd really like to see a test

Also, no need to check in the line:


That's to help you when composing your change log.
Comment 7 mitz 2006-11-14 09:28:30 PST
Created attachment 11519 [details]
Test case
Comment 8 Alexey Proskuryakov 2006-11-14 11:06:24 PST
Committed revision 17761 (with test).