Bug 115749 - [BlackBerry] Increase the padding size for caret based scrolling.
Summary: [BlackBerry] Increase the padding size for caret based scrolling.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mike Fenton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-07 12:38 PDT by Mike Fenton
Modified: 2013-05-07 13:29 PDT (History)
1 user (show)

See Also:


Attachments
Patch (3.62 KB, patch)
2013-05-07 12:40 PDT, Mike Fenton
no flags Details | Formatted Diff | Diff
Updated Patch (3.34 KB, patch)
2013-05-07 12:47 PDT, Mike Fenton
no flags Details | Formatted Diff | Diff
Another updated patch (3.36 KB, patch)
2013-05-07 12:48 PDT, Mike Fenton
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Fenton 2013-05-07 12:38:53 PDT
Reduce the number of scrolls required.
Comment 1 Mike Fenton 2013-05-07 12:40:20 PDT
Created attachment 200959 [details]
Patch
Comment 2 WebKit Commit Bot 2013-05-07 12:42:26 PDT
Attachment 200959 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/blackberry/ChangeLog', u'Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp']" exit_code: 1
Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:1372:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Mike Fenton 2013-05-07 12:47:29 PDT
Created attachment 200962 [details]
Updated Patch
Comment 4 WebKit Commit Bot 2013-05-07 12:48:55 PDT
Attachment 200962 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/blackberry/ChangeLog', u'Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp']" exit_code: 1
Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:1372:  Tab found; better to use spaces  [whitespace/tab] [1]
Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:1373:  Tab found; better to use spaces  [whitespace/tab] [1]
Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:1374:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:1375:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Total errors found: 4 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Mike Fenton 2013-05-07 12:48:56 PDT
Created attachment 200963 [details]
Another updated patch
Comment 6 Rob Buis 2013-05-07 13:02:04 PDT
Comment on attachment 200963 [details]
Another updated patch

LGTM.
Comment 7 WebKit Commit Bot 2013-05-07 13:29:18 PDT
Comment on attachment 200963 [details]
Another updated patch

Clearing flags on attachment: 200963

Committed r149689: <http://trac.webkit.org/changeset/149689>
Comment 8 WebKit Commit Bot 2013-05-07 13:29:19 PDT
All reviewed patches have been landed.  Closing bug.