Bug 115732 - [Automake] Pass --no-demangle to the linker by default to get the mangled symbols
Summary: [Automake] Pass --no-demangle to the linker by default to get the mangled sym...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords:
Depends on:
Blocks: 96514
  Show dependency tree / graph
 
Reported: 2013-05-07 09:38 PDT by Zan Dobersek
Modified: 2013-05-08 00:03 PDT (History)
1 user (show)

See Also:

Attachments
Patch (1.65 KB, patch)
2013-05-07 09:47 PDT, Zan Dobersek 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2013-05-07 09:38:05 PDT 
[Automake] Pass --no-demangle to the linker by default to get the mangled symbols
Comment 1 Zan Dobersek 2013-05-07 09:47:39 PDT 
Created attachment 200921 [details]
Patch
Comment 2 Gustavo Noronha (kov) 2013-05-07 15:18:12 PDT 
Comment on attachment 200921 [details]
Patch

LGTM, except I'm worry it works in our jhbuilt environments just because it sets LDFLAGS, so your += works. If you could make sure it also works when no LDFLAGS are set in the environment, that would be great.
Comment 3 Zan Dobersek 2013-05-07 23:59:41 PDT 
It also works with no LDFLAGS present in the environment. Thanks for the review!
Comment 4 Zan Dobersek 2013-05-08 00:03:06 PDT 
Comment on attachment 200921 [details]
Patch

Clearing flags on attachment: 200921

Committed r149714: <http://trac.webkit.org/changeset/149714>
Comment 5 Zan Dobersek 2013-05-08 00:03:13 PDT 
All reviewed patches have been landed.  Closing bug.