Bug 115723 – Make optional arguments in CanvasRenderingContext2D match the spec.

• Status: RESOLVED
• Resolution: FIXED
• Component: Canvas

[Dongseong Hwang]

WebKit r98985 set many arguments optional although the canvas spec[1] does not 
indicate. So this patch corrects CanvasRenderingContext2D.idl to match the spec. 

[1] http://www.w3.org/html/wg/drafts/2dcontext/html5_canvas/

[Dongseong Hwang]

Created attachment 200911 [details]
Patch

[Dongseong Hwang]

I submitted this patch in Blink also: https://codereview.chromium.org/14654002/

[Dongseong Hwang]

In Blink, this patch is landed.

[Dean Jackson]

Comment on attachment 200911 [details]
Patch

Thanks!

[Dongseong Hwang]

Thank you too! :)

[WebKit Commit Bot]

Comment on attachment 200911 [details]
Patch

Rejecting attachment 200911 [details] from commit-queue.

New failing tests:
inspector/profiler/canvas2d/canvas2d-profiler-capturing-basics.html
Full output: http://webkit-queues.appspot.com/results/379230

[WebKit Commit Bot]

Created attachment 200943 [details]
Archive of layout-test-results from webkit-cq-03 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: webkit-cq-03  Port: mac-mountainlion  Platform: Mac OS X 10.8.3

[Build Bot]

Comment on attachment 200911 [details]
Patch

Attachment 200911 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/350176

New failing tests:
inspector/profiler/canvas2d/canvas2d-profiler-capturing-basics.html

[Build Bot]

Created attachment 200979 [details]
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-15  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.2

[Build Bot]

Comment on attachment 200911 [details]
Patch

Attachment 200911 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/356177

New failing tests:
media/video-zoom.html
inspector/profiler/canvas2d/canvas2d-profiler-capturing-basics.html

[Build Bot]

Created attachment 200983 [details]
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-01  Port: mac-mountainlion  Platform: Mac OS X 10.8.2

[Dongseong Hwang]

Created attachment 201030 [details]
Patch to land

[Dongseong Hwang]

Comment on attachment 201030 [details]
Patch to land

I missed inspector/profiler/canvas2d/canvas2d-profiler-capturing-basics.html
I assumed all canvas tests are in canvas and fast/canvas.

[WebKit Commit Bot]

Comment on attachment 201030 [details]
Patch to land

Clearing flags on attachment: 201030

Committed r149723: <http://trac.webkit.org/changeset/149723>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.