Bug 115713 - [EFL] Refactor ewk_view_scroll to remove internal structure.
Summary: [EFL] Refactor ewk_view_scroll to remove internal structure.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryuan Choi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-06 23:26 PDT by Ryuan Choi
Modified: 2013-06-13 00:53 PDT (History)
5 users (show)

See Also:


Attachments
Patch (20.60 KB, patch)
2013-05-06 23:32 PDT, Ryuan Choi
gyuyoung.kim: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryuan Choi 2013-05-06 23:26:07 PDT
After removed c-ism from WebKit/Efl, we don't need to keep the internal structures like Ewk_Scroll_Request.
It's just used to pass scrollRect and delta to c files.
Comment 1 Ryuan Choi 2013-05-06 23:32:33 PDT
Created attachment 200876 [details]
Patch
Comment 2 Gyuyoung Kim 2013-06-13 00:45:28 PDT
Comment on attachment 200876 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=200876&action=review

Looks fine refactoring. r=me.

> Source/WebKit/efl/ChangeLog:8
> +        After removed c-ism from WebKit/Efl, There are no reason to keep internal

are -> is ?
Comment 3 Ryuan Choi 2013-06-13 00:52:56 PDT
Committed r151540: <http://trac.webkit.org/changeset/151540>
Comment 4 Ryuan Choi 2013-06-13 00:53:23 PDT
(In reply to comment #2)
> (From update of attachment 200876 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=200876&action=review
> 
> Looks fine refactoring. r=me.
> 
> > Source/WebKit/efl/ChangeLog:8
> > +        After removed c-ism from WebKit/Efl, There are no reason to keep internal
> 
> are -> is ?

Thank you.
Landed after fixed.