WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED INVALID
115696
Remove enforcement for having the first child as RenderInline.
https://bugs.webkit.org/show_bug.cgi?id=115696
Summary
Remove enforcement for having the first child as RenderInline.
Ryosuke Niwa
Reported
2013-05-06 19:48:21 PDT
We should consider merging
https://chromium.googlesource.com/chromium/blink/+/a7e0d7b2e1a26326adf18b6d39c15beb960b5f59
Remove enforcement for having the first child as RenderInline. If the added cue is not inline then most almost certainly an external factor (e.g. such as an external stylesheet as in the testcase) has modified the default display: value for the cue. If this is the case, there's no need or reason to run the WebVTT algorithm for positioning the as we don't really have to support these cases.
Attachments
Add attachment
proposed patch, testcase, etc.
Eric Carlson
Comment 1
2013-05-08 14:24:00 PDT
The test case attached to that bug does not crash for me, but I would be surprised if it crashed Chromium even without the patch because of the way text tracks work. While investigating it I did find another crash, which I fixed in
http://trac.webkit.org/changeset/149766
.
Eric Carlson
Comment 2
2013-05-08 14:24:37 PDT
Marking as Invalid for now. We can reopen if I am wrong.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug