Bug 115689 - Simplify FrameLoaderStateMachine and FrameLoader::transitionToCommitted().
Summary: Simplify FrameLoaderStateMachine and FrameLoader::transitionToCommitted().
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: BlinkMergeCandidate
Depends on:
Blocks:
 
Reported: 2013-05-06 19:09 PDT by Ryosuke Niwa
Modified: 2022-09-23 18:07 PDT (History)
14 users (show)

See Also:

Attachments
WIP Patch (18.26 KB, patch)
2022-09-15 17:04 PDT, Don Olmstead 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
WIP Patch (18.53 KB, patch)
2022-09-15 17:12 PDT, Don Olmstead 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
WIP Patch (19.10 KB, patch)
2022-09-15 17:27 PDT, Don Olmstead 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Ahmad Saleem 2022-09-14 15:50:57 PDT 
Trying this in https://github.com/WebKit/WebKit/pull/4364
Comment 2 Don Olmstead 2022-09-15 17:04:51 PDT Comment hidden (obsolete)
Comment 3 Don Olmstead 2022-09-15 17:12:39 PDT Comment hidden (obsolete)
Comment 4 Don Olmstead 2022-09-15 17:27:52 PDT 
Created attachment 462378 [details]
WIP Patch
Comment 5 Ahmad Saleem 2022-09-23 18:07:23 PDT 
I tried to land this via PR:

https://github.com/WebKit/WebKit/pull/4364

but I was not successful compared to Don and had following build failures:

./loader/FrameLoader.cpp:4264:59: error: no member named 'DisplayingInitialEmptyDocumentPostCommit' in 'WebCore::FrameLoaderStateMachine'; did you mean 'DisplayingInitialEmptyDocument'?

Further based on the result from Don, there are crashes and blood bath with this change and there might be more to fix than just doing merge.

From the benefits perspective, I think @rniwa can pitch in better but if there is a need to keep this bug open or invest in this simplification, we can. Else we can close this and move on.

Thanks!