NEW 115689
Simplify FrameLoaderStateMachine and FrameLoader::transitionToCommitted(). 
https://bugs.webkit.org/show_bug.cgi?id=115689
Summary Simplify FrameLoaderStateMachine and FrameLoader::transitionToCommitted().
Attachments
WIP Patch (18.26 KB, patch)
2022-09-15 17:04 PDT, Don Olmstead 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
WIP Patch (18.53 KB, patch)
2022-09-15 17:12 PDT, Don Olmstead 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
WIP Patch (19.10 KB, patch)
2022-09-15 17:27 PDT, Don Olmstead 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Ahmad Saleem
Comment 1 2022-09-14 15:50:57 PDT
Trying this in https://github.com/WebKit/WebKit/pull/4364
Don Olmstead
Comment 2 2022-09-15 17:04:51 PDT Comment hidden (obsolete)
Don Olmstead
Comment 3 2022-09-15 17:12:39 PDT Comment hidden (obsolete)
Don Olmstead
Comment 4 2022-09-15 17:27:52 PDT
Created attachment 462378 [details] WIP Patch
Ahmad Saleem
Comment 5 2022-09-23 18:07:23 PDT
I tried to land this via PR: https://github.com/WebKit/WebKit/pull/4364 but I was not successful compared to Don and had following build failures: ./loader/FrameLoader.cpp:4264:59: error: no member named 'DisplayingInitialEmptyDocumentPostCommit' in 'WebCore::FrameLoaderStateMachine'; did you mean 'DisplayingInitialEmptyDocument'? Further based on the result from Don, there are crashes and blood bath with this change and there might be more to fix than just doing merge. From the benefits perspective, I think @rniwa can pitch in better but if there is a need to keep this bug open or invest in this simplification, we can. Else we can close this and move on. Thanks!
Note You need to log in before you can comment on or make changes to this bug.