RESOLVED FIXED 115675
Hittest finds the truncated text instead of the floating input, when the input is clicked. 
https://bugs.webkit.org/show_bug.cgi?id=115675
Summary Hittest finds the truncated text instead of the floating input, when the inpu...
zalan
Reported 2013-05-06 14:11:42 PDT
<style> div { text-overflow: ellipsis; overflow: hidden; white-space: nowrap; } input { float: right; } </style> <div><input type='text'>long long long long long text</div> 1, input is clicked. 2, text gets the hit test, even though it is truncated right before the floating input box. attached test case
Attachments
reduced test case (678 bytes, text/html)
2013-05-06 14:12 PDT, zalan 		no flags
Details
Patch (12.78 KB, patch)
2013-05-09 04:40 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Patch (12.85 KB, patch)
2013-05-11 07:18 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Patch (15.10 KB, patch)
2013-05-19 08:41 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Patch (13.14 KB, patch)
2013-06-23 23:51 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2013-05-06 14:12:10 PDT
Created attachment 200808 [details] reduced test case
zalan
Comment 2 2013-05-06 14:19:39 PDT
1. We need to use the m_truncation at InlineTextBox::nodeAtPoint() to make sure truncated text is ignored while hittesting. 2, We need to teach the parent RootInlineBox to be smarter at hittesting (InlineFlowBox::nodeAtPoint()) to figure out that the truncated part.
zalan
Comment 3 2013-05-06 15:11:46 PDT
[12:57am] dhyatt: if i were writing this feature from scratch i would probably have let the child elements overflow [12:57am] dhyatt: but shrink the root line [12:57am] dhyatt: might be some reason why i didn't do that though [12:58am] dhyatt: easiest fix at this point is to just hack it then prob [12:58am] dhyatt: painting must just be hacking it [12:58am] dhyatt: so hit testing can too
zalan
Comment 4 2013-05-06 15:12:21 PDT
<rdar://problem/13008605>
zalan
Comment 5 2013-05-09 04:40:43 PDT
Created attachment 201179 [details] Patch
zalan
Comment 6 2013-05-09 12:57:27 PDT
will be moving layout test to /fast/css
zalan
Comment 7 2013-05-11 07:18:01 PDT
Created attachment 201456 [details] Patch
Dave Hyatt
Comment 8 2013-05-16 08:55:58 PDT
Comment on attachment 201456 [details] Patch Make a vertical-rl test too.
zalan
Comment 9 2013-05-19 08:41:37 PDT
Created attachment 202237 [details] Patch
zalan
Comment 10 2013-05-19 08:48:14 PDT
(In reply to comment #8) > (From update of attachment 201456 [details]) > Make a vertical-rl test too. added (best effort). Vertical text truncate bug is tracked here: bug #116413
zalan
Comment 11 2013-06-23 23:51:38 PDT
Created attachment 205277 [details] Patch
WebKit Commit Bot
Comment 12 2013-06-24 00:32:51 PDT
Comment on attachment 205277 [details] Patch Clearing flags on attachment: 205277 Committed r151894: <http://trac.webkit.org/changeset/151894>
WebKit Commit Bot
Comment 13 2013-06-24 00:32:54 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.