Hi, javascript binding generator has a few special cases which we ideally would like to remove. This bug is about removing the special case for HTMLPropertiesCollection/DOMNamedFlowCollection and put the nameGetter function in custom binding files.
Created attachment 200770 [details] patch proposal
Comment on attachment 200770 [details] patch proposal View in context: https://bugs.webkit.org/attachment.cgi?id=200770&action=review > Source/WebCore/bindings/js/JSDOMNamedFlowCollectionCustom.cpp:2 > + * Copyright (C) 2013 Samsung Electronics. All rights reserved. Since you’re moving the code, you need to credit the original authors. > Source/WebCore/bindings/js/JSHTMLPropertiesCollectionCustom.cpp:2 > + * Copyright (C) 2013 Samsung Electronics. All rights reserved. Ditto.
Created attachment 200802 [details] updated patch
Comment on attachment 200802 [details] updated patch View in context: https://bugs.webkit.org/attachment.cgi?id=200802&action=review > Source/WebCore/bindings/js/JSDOMNamedFlowCollectionCustom.cpp:2 > + * Copyright (C) 2012 Motorola Mobility Inc. All rights reserved. This code was added by Adobe. See http://trac.webkit.org/changeset/126627. So you probably need to credit both Adobe and Motorola Mobility. > Source/WebCore/bindings/js/JSHTMLPropertiesCollectionCustom.cpp:2 > + * Copyright (C) 2012 Motorola Mobility Inc. All rights reserved. Ditto.
Created attachment 200809 [details] updated patch: add adobe credits
Comment on attachment 200809 [details] updated patch: add adobe credits View in context: https://bugs.webkit.org/attachment.cgi?id=200809&action=review > Source/WebCore/bindings/js/JSDOMNamedFlowCollectionCustom.cpp:4 > + * Copyright (C) 2012 Motorola Mobility Inc. All rights reserved. > + * Copyright (C) 2012 Adobe Systems Incorporated. All rights reserved > + * Copyright (C) 2013 Samsung Electronics. All rights reserved. Finally, you also need to add Apple since it’s touched by http://trac.webkit.org/changeset/137107, http://trac.webkit.org/changeset/113387, and http://trac.webkit.org/changeset/116828. > Source/WebCore/bindings/js/JSHTMLPropertiesCollectionCustom.cpp:4 > + * Copyright (C) 2012 Motorola Mobility Inc. All rights reserved. > + * Copyright (C) 2012 Adobe Systems Incorporated. All rights reserved > + * Copyright (C) 2013 Samsung Electronics. All rights reserved. Ditto.
Created attachment 200813 [details] updated patch: add apple credits
Comment on attachment 200813 [details] updated patch: add apple credits Let’s wait for EWS.
Comment on attachment 200813 [details] updated patch: add apple credits Attachment 200813 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/289229
Created attachment 200932 [details] updated patch: reference new files in JSBindingsAllInOne.cpp
Comment on attachment 200932 [details] updated patch: reference new files in JSBindingsAllInOne.cpp Rejecting attachment 200932 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 200932, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: fset -28 lines). patching file Source/WebCore/bindings/js/JSBindingsAllInOne.cpp patching file Source/WebCore/bindings/js/JSDOMNamedFlowCollectionCustom.cpp patching file Source/WebCore/bindings/js/JSHTMLPropertiesCollectionCustom.cpp patching file Source/WebCore/bindings/scripts/CodeGeneratorJS.pm Hunk #1 succeeded at 2586 (offset 2 lines). Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Ryosuke Niwa']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.appspot.com/results/404783
Created attachment 203740 [details] updated patch: handle VS2005 files removal
Comment on attachment 203740 [details] updated patch: handle VS2005 files removal Looks fine, r=me. Eventually, we want to get rid of custom code for named getters and add proper support to the generator. However, this is good in the meantime.
Comment on attachment 203740 [details] updated patch: handle VS2005 files removal Rejecting attachment 203740 [details] from commit-queue. a.renevier@samsung.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights.
Comment on attachment 203740 [details] updated patch: handle VS2005 files removal Hopefully, it should work now
Comment on attachment 203740 [details] updated patch: handle VS2005 files removal Rejecting attachment 203740 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 203740, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: g file Source/WebCore/bindings/js/JSDOMNamedFlowCollectionCustom.cpp patching file Source/WebCore/bindings/js/JSHTMLPropertiesCollectionCustom.cpp patching file Source/WebCore/bindings/scripts/CodeGeneratorJS.pm Hunk #1 FAILED at 2638. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/bindings/scripts/CodeGeneratorJS.pm.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Christophe Dumez']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.appspot.com/results/1065151