Bug 115649 - [CSS Exclusions] shape-inside, shape-padding, polygon test failing when subpixel layout is disabled
Summary: [CSS Exclusions] shape-inside, shape-padding, polygon test failing when subpi...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 115292
  Show dependency tree / graph
 
Reported: 2013-05-06 08:49 PDT by Hans Muller
Modified: 2013-05-07 15:53 PDT (History)
1 user (show)

See Also:

Attachments
Patch (5.93 KB, patch)
2013-05-07 12:44 PDT, Hans Muller 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hans Muller 2013-05-06 08:49:19 PDT 
The following test started failing when subpixel layout was disabled for the OSX port (see http://trac.webkit.org/changeset/149224).

fast/exclusions/shape-inside/shape-inside-polygon-padding-002.html
Comment 1 Hans Muller 2013-05-07 12:44:56 PDT 
Created attachment 200961 [details]
Patch

Another correction of a padded shape test that failed when subpixel layout was disabled. This test puts a cross pattern made of five Ahem characters on three lines, within a padded diamond polygon. The left edges of each line depend on the intersection of the padded polygon's edges with the top of each line, which makes predicting the exact values unreliable. So we just verify that the left edges of each line are within a pixel of the ideal value. This change is very similar to the one made for https://bugs.webkit.org/show_bug.cgi?id=115490.
Comment 2 WebKit Commit Bot 2013-05-07 15:53:28 PDT 
Comment on attachment 200961 [details]
Patch

Clearing flags on attachment: 200961

Committed r149699: <http://trac.webkit.org/changeset/149699>
Comment 3 WebKit Commit Bot 2013-05-07 15:53:29 PDT 
All reviewed patches have been landed.  Closing bug.