Build with GCC 4.8 fails because of -Wmaybe-uninitialized

[Andras Becsi]

Build with GCC 4.8 fails because of -Wmaybe-uninitialized

[Andras Becsi]

Created attachment 200703 [details]
Patch

[Mark Hahnenberg]

Comment on attachment 200703 [details]
Patch

Hmm, maybe there's a way  to make it so OptionRange has a trivial constructor and then we can manually initialize the fields with an init method? I'm leery of disabling warnings.

[Michael Saboff]

I had a trivial constructor but got these messages from clang:

/Volumes/Data/src/webkit.work/Source/JavaScriptCore/runtime/Options.cpp:166:25: error: call to deleted constructor of 'Options::Entry [57]'
Options::Entry Options::s_options[Options::numberOfOptions];
                        ^
In file included from /Volumes/Data/src/webkit.work/Source/JavaScriptCore/runtime/Options.cpp:27:
/Volumes/Data/src/webkit.work/Source/JavaScriptCore/runtime/Options.h:222:12: note: function has been explicitly marked deleted here
    struct Entry {
           ^
1 error generated.

Here is the constructor:
    OptionRange()
        : m_state(Uninitialized)
        , m_rangeString(0)
        , m_lowLimit(0)
        , m_highLimit(0)
    {
    }

What line is it complaining may be uninitialized?

[Andras Becsi]

Created attachment 200731 [details]
Patch

[Andras Becsi]

(In reply to comment #3)
> I had a trivial constructor but got these messages from clang:
> 
> /Volumes/Data/src/webkit.work/Source/JavaScriptCore/runtime/Options.cpp:166:25: error: call to deleted constructor of 'Options::Entry [57]'
> Options::Entry Options::s_options[Options::numberOfOptions];
>                         ^
> In file included from /Volumes/Data/src/webkit.work/Source/JavaScriptCore/runtime/Options.cpp:27:
> /Volumes/Data/src/webkit.work/Source/JavaScriptCore/runtime/Options.h:222:12: note: function has been explicitly marked deleted here
>     struct Entry {
>            ^
> 1 error generated.
> 
> Here is the constructor:
>     OptionRange()
>         : m_state(Uninitialized)
>         , m_rangeString(0)
>         , m_lowLimit(0)
>         , m_highLimit(0)
>     {
>     }

The problem with this is that a constructor with an initializer-list is not trivial any more and hence can not be placed into a union,which can only hold POD.
With "trivial constructor" I actually meant "default constructor with no initializer list and empty body" (equivalent with an implicitly-declared constructor generated by the compiler).

GCC has an informative error message with the above constructor:

error: member 'JSC::OptionRange JSC::Options::Entry::<anonymous union>::optionRangeVal' with constructor not allowed in union
note: unrestricted unions only available with -std=c++11 or -std=gnu++11

> 
> What line is it complaining may be uninitialized?

/home/abecsi/devel/git/webkit-git-svn/Source/JavaScriptCore/runtime/Options.cpp:120:17: error: 'value.JSC::OptionRange::m_state' may be used uninitialized in this function [-Werror=maybe-uninitialized]

This is actually valid, since in Options::setOption the values are not initialized, hence the new patch.

[Andras Becsi]

Comment on attachment 200731 [details]
Patch

Clearing flags on attachment: 200731

Committed r149622: <http://trac.webkit.org/changeset/149622>

[Andras Becsi]

All reviewed patches have been landed.  Closing bug.