Bug 115640 – Text should be constructable

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Erik Arvidsson]

http://dom.spec.whatwg.org/#interface-text

Make Text constructable so that one can do "new Text('abc')" instead of "document.createTexte('abc')"

[László Langó]

Created attachment 220701 [details]
Patch

[László Langó]

Created attachment 220715 [details]
Patch

[EFL EWS Bot]

Comment on attachment 220715 [details]
Patch

Attachment 220715 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/5110474479763456

[László Langó]

Created attachment 220817 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 220817 [details]
Patch

Rejecting attachment 220817 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 220817, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
    -> origin/master
Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ...
Currently at 161866 = 41d60a4a901854d1207540d97b72c55011be5f69
r161867 = 8c325df8e8ed83167416651d0b713fca53dfb8fe
r161868 = 89061aa53453fa276ca9953d05b40a3277a033e8
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.

Full output: http://webkit-queues.appspot.com/results/6009007810543616

[László Langó]

Created attachment 221026 [details]
patch for landing

[WebKit Commit Bot]

Comment on attachment 221026 [details]
patch for landing

Clearing flags on attachment: 221026

Committed r161876: <http://trac.webkit.org/changeset/161876>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Sam Weinig]

Comment on attachment 221026 [details]
patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=221026&action=review

> Source/WebCore/dom/Text.h:39
> +    static PassRefPtr<Text> create(ScriptExecutionContext&, const String&);

Why ScriptExecutionContext? This always need to be a Document.

[László Langó]

(In reply to comment #9)
> (From update of attachment 221026 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=221026&action=review
> 
> > Source/WebCore/dom/Text.h:39
> > +    static PassRefPtr<Text> create(ScriptExecutionContext&, const String&);
> 
> Why ScriptExecutionContext? This always need to be a Document.

Basically because this is how in the Blink did it. :) https://chromium.googlesource.com/chromium/blink/+/cdd5a914daf3862379a5ce4596149bd690d0fa08

I'm not sure I fully understand, but we have only this in bindings/scripts/IDLAttributes (ConstructorCallWith=ScriptExecutionContext). A don't think that this is a problem, because we can safely convert it into a document with the toDocument function. Do you know another equivalent way how can we do this?