If the m_maxDeadCapacity == 0, MemoryCache::prune() always tries to prune Resources. But if m_deadSize is also 0, pruning is unnecessary. I removed one condition in the "fast path". Is it possible that in some case this condition is required for properly work?
Created attachment 200652 [details] patch
This patch is not currently marked for review. Did you intend to submit it for review? You can still do that via Details link to the right of the patch.
Comment on attachment 200652 [details] patch This looks fine to me. Is there any case we now fail, such as 'm_maxDeadCapacity == 0' and 'm_deadSize < 0' that might now get through and cause a problem?
(In reply to comment #3) > (From update of attachment 200652 [details]) > This looks fine to me. Is there any case we now fail, such as 'm_maxDeadCapacity == 0' and 'm_deadSize < 0' that might now get through and cause a problem? I don't see any case we now can fail. m_deadSize is unsigned, so it can't be < 0. When m_maxDeadCapacity == 0, we need to prune resources only when m_deadSize > 0, so there condition 'm_deadSize <= m_maxDeadCapacity' is enough.
Comment on attachment 200652 [details] patch I forgot about this! Looks good. r=me
Comment on attachment 200652 [details] patch Rejecting attachment 200652 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 200652, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!. Full output: http://webkit-queues.appspot.com/results/17138231
Created attachment 215636 [details] Patch
Created attachment 215649 [details] Patch
Comment on attachment 215649 [details] Patch Clearing flags on attachment: 215649 Committed r158357: <http://trac.webkit.org/changeset/158357>