Initialize WebKitWebPlugin path in webkitwebplugin.cpp to prevent double-free on OpenBSD: https://bugzilla.gnome.org/show_bug.cgi?id=684245#c20
Created attachment 200639 [details] Proposed patch
Comment on attachment 200639 [details] Proposed patch Oh!, this happens because webkitwebplugin is doing new WebKitWebPluginPrivate(). I think a better fix would be to use GOwnPtr<char> for the path. GOwnPtr initializes the internal pointer on construction and you can remove all the g_free.
Created attachment 200664 [details] Proposed patch v2 WebKitWebPlugin path and also error variable in webkit_web_plugin_get_path are now using GOwnPtr
Attachment 200664 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/gtk/ChangeLog', u'Source/WebKit/gtk/webkit/webkitwebplugin.cpp', u'Source/WebKit/gtk/webkit/webkitwebpluginprivate.h']" exit_code: 1 Source/WebKit/gtk/webkit/webkitwebpluginprivate.h:25: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 200664 [details] Proposed patch v2 Looks good to me, but please fix the style error.
Created attachment 200877 [details] Proposed patch v3 Fixes style error.
Comment on attachment 200877 [details] Proposed patch v3 Clearing flags on attachment: 200877 Committed r149666: <http://trac.webkit.org/changeset/149666>
All reviewed patches have been landed. Closing bug.