Bug 115622 - [BLACKBERRY]clean up load interface in WebPage
Summary: [BLACKBERRY]clean up load interface in WebPage
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-05 23:07 PDT by xuefeiren
Modified: 2013-05-07 22:07 PDT (History)
5 users (show)

See Also:

Attachments
clean up load interface in WebPage (10.36 KB, patch)
2013-05-05 23:27 PDT, xuefeiren 		rwlbuis: review+
Details | Formatted Diff | Diff
clean up load interface in WebPage (10.49 KB, patch)
2013-05-07 18:41 PDT, xuefeiren 		no flags Details | Formatted Diff | Diff
clean up load interface in WebPage (10.49 KB, patch)
2013-05-07 19:06 PDT, xuefeiren 		no flags Details | Formatted Diff | Diff
clean up load interface in WebPage (10.36 KB, patch)
2013-05-07 19:08 PDT, xuefeiren 		commit-queue: commit-queue-
Details | Formatted Diff | Diff
clean up load interface in WebPage (20.80 KB, patch)
2013-05-07 19:49 PDT, xuefeiren 		no flags Details | Formatted Diff | Diff
clean up load interface in WebPage (10.23 KB, patch)
2013-05-07 19:52 PDT, xuefeiren 		no flags Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description xuefeiren 2013-05-05 23:07:23 PDT 
Clean up load interface in WebPage

internal PR: https://bugzilla.qnx.com/bugzilla/show_bug.cgi?id=315535
internal reviewed by Marry Wu
Comment 1 xuefeiren 2013-05-05 23:27:50 PDT 
Created attachment 200605 [details]
clean up load interface in WebPage

clean up load interface in WebPage
Comment 2 Rob Buis 2013-05-07 08:49:17 PDT 
Comment on attachment 200605 [details]
clean up load interface in WebPage

View in context: https://bugs.webkit.org/attachment.cgi?id=200605&action=review

Looks good, but please fix the ChangeLog and then ask Charles or Mary to commit.

> Source/WebKit/blackberry/ChangeLog:8
> +        Internal reviewd by : Marry WU

It is reviewed by, and "Mary Wu".
Comment 3 xuefeiren 2013-05-07 18:41:05 PDT 
Created attachment 201012 [details]
clean up load interface in WebPage

commit-queue?
Comment 4 Rob Buis 2013-05-07 18:57:40 PDT 
Comment on attachment 201012 [details]
clean up load interface in WebPage

View in context: https://bugs.webkit.org/attachment.cgi?id=201012&action=review

> Source/WebKit/blackberry/ChangeLog:5
> +        Reviewed by Rob Buis and Marry Wu.

This will probably not work. You should ask Charles, Mary or Ming how to fix it.
Comment 5 xuefeiren 2013-05-07 19:06:55 PDT 
Created attachment 201014 [details]
clean up load interface in WebPage

commit ?
Comment 6 xuefeiren 2013-05-07 19:08:19 PDT 
Created attachment 201015 [details]
clean up load interface in WebPage

commit?
Comment 7 Charles Wei 2013-05-07 19:28:25 PDT 
Comment on attachment 201015 [details]
clean up load interface in WebPage

Commit.
Comment 8 WebKit Commit Bot 2013-05-07 19:30:33 PDT 
Comment on attachment 201015 [details]
clean up load interface in WebPage

Rejecting attachment 201015 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 201015, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
patching file Source/WebKit/blackberry/Api/WebPage_p.h
patching file Source/WebKit/blackberry/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.cpp
Hunk #1 FAILED at 1200.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.cpp.rej

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.appspot.com/results/377497
Comment 9 xuefeiren 2013-05-07 19:49:16 PDT 
Created attachment 201020 [details]
clean up load interface in WebPage

commit?
Comment 10 xuefeiren 2013-05-07 19:52:48 PDT 
Created attachment 201021 [details]
clean up load interface in WebPage

commit?
Comment 11 Charles Wei 2013-05-07 20:00:46 PDT 
Comment on attachment 201021 [details]
clean up load interface in WebPage

re-commit after rebase to resolve the conflict.
Comment 12 WebKit Commit Bot 2013-05-07 22:07:46 PDT 
Comment on attachment 201021 [details]
clean up load interface in WebPage

Clearing flags on attachment: 201021

Committed r149711: <http://trac.webkit.org/changeset/149711>
Comment 13 WebKit Commit Bot 2013-05-07 22:07:49 PDT 
All reviewed patches have been landed.  Closing bug.