Bug 115622 – [BLACKBERRY]clean up load interface in WebPage

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit BlackBerry

[xuefeiren]

Clean up load interface in WebPage

internal PR: https://bugzilla.qnx.com/bugzilla/show_bug.cgi?id=315535
internal reviewed by Marry Wu

[xuefeiren]

Created attachment 200605 [details]
clean up load interface in WebPage

clean up load interface in WebPage

[Rob Buis]

Comment on attachment 200605 [details]
clean up load interface in WebPage

View in context: https://bugs.webkit.org/attachment.cgi?id=200605&action=review

Looks good, but please fix the ChangeLog and then ask Charles or Mary to commit.

> Source/WebKit/blackberry/ChangeLog:8
> +        Internal reviewd by : Marry WU

It is reviewed by, and "Mary Wu".

[xuefeiren]

Created attachment 201012 [details]
clean up load interface in WebPage

commit-queue?

[Rob Buis]

Comment on attachment 201012 [details]
clean up load interface in WebPage

View in context: https://bugs.webkit.org/attachment.cgi?id=201012&action=review

> Source/WebKit/blackberry/ChangeLog:5
> +        Reviewed by Rob Buis and Marry Wu.

This will probably not work. You should ask Charles, Mary or Ming how to fix it.

[xuefeiren]

Created attachment 201014 [details]
clean up load interface in WebPage

commit ?

[xuefeiren]

Created attachment 201015 [details]
clean up load interface in WebPage

commit?

[Charles Wei]

Comment on attachment 201015 [details]
clean up load interface in WebPage

Commit.

[WebKit Commit Bot]

Comment on attachment 201015 [details]
clean up load interface in WebPage

Rejecting attachment 201015 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 201015, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
patching file Source/WebKit/blackberry/Api/WebPage_p.h
patching file Source/WebKit/blackberry/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.cpp
Hunk #1 FAILED at 1200.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.cpp.rej

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.appspot.com/results/377497

[xuefeiren]

Created attachment 201020 [details]
clean up load interface in WebPage

commit?

[xuefeiren]

Created attachment 201021 [details]
clean up load interface in WebPage

commit?

[Charles Wei]

Comment on attachment 201021 [details]
clean up load interface in WebPage

re-commit after rebase to resolve the conflict.

[WebKit Commit Bot]

Comment on attachment 201021 [details]
clean up load interface in WebPage

Clearing flags on attachment: 201021

Committed r149711: <http://trac.webkit.org/changeset/149711>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.