WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
115596
Update code generators to handle a new JavaScript file for snapshotted plug-ins
https://bugs.webkit.org/show_bug.cgi?id=115596
Summary
Update code generators to handle a new JavaScript file for snapshotted plug-ins
Antoine Quint
Reported
2013-05-04 13:58:06 PDT
Update code generators to handle a new JavaScript file for snapshotted plug-ins
Attachments
Patch
(18.13 KB, patch)
2013-05-04 14:00 PDT
,
Antoine Quint
no flags
Details
Formatted Diff
Diff
Patch for landing
(18.16 KB, patch)
2013-05-04 14:10 PDT
,
Antoine Quint
no flags
Details
Formatted Diff
Diff
Patch for landing
(18.30 KB, patch)
2013-05-04 14:17 PDT
,
Antoine Quint
no flags
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Antoine Quint
Comment 1
2013-05-04 14:00:53 PDT
Created
attachment 200542
[details]
Patch
Dean Jackson
Comment 2
2013-05-04 14:03:08 PDT
Comment on
attachment 200542
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=200542&action=review
> Source/WebCore/ChangeLog:22 > + * CMakeLists.txt: > + * DerivedSources.cpp: > + * DerivedSources.make: > + * DerivedSources.pri: > + * GNUmakefile.am: > + * GNUmakefile.list.am: > + * Resources/plugIns.js: Added. > + * WebCore.vcproj/WebCore.vcproj: > + * WebCore.vcxproj/WebCore.vcxproj: > + * WebCore.vcxproj/WebCore.vcxproj.filters: > + * WebCore.xcodeproj/project.pbxproj:
You should at least give quick descriptions of what you're changing here, especially when you're adding new rule blocks.
WebKit Commit Bot
Comment 3
2013-05-04 14:05:10 PDT
Comment on
attachment 200542
[details]
Patch Rejecting
attachment 200542
[details]
from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 200542, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: patching file Source/WebCore/GNUmakefile.list.am Hunk #1 succeeded at 891 (offset -2 lines). patch: **** Only garbage was found in the patch input. fatal: pathspec 'Source/WebCore/Resources/plugIns.js' did not match any files Failed to git add Source/WebCore/Resources/plugIns.js. at /Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply line 448. Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Dean Jackson']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Full output:
http://webkit-queues.appspot.com/results/357795
Antoine Quint
Comment 4
2013-05-04 14:10:05 PDT
Created
attachment 200543
[details]
Patch for landing
WebKit Commit Bot
Comment 5
2013-05-04 14:11:28 PDT
Comment on
attachment 200543
[details]
Patch for landing Rejecting
attachment 200543
[details]
from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 200543, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: urce/WebCore/DerivedSources.pri patching file Source/WebCore/GNUmakefile.am patching file Source/WebCore/GNUmakefile.list.am patch: **** Only garbage was found in the patch input. fatal: pathspec 'Source/WebCore/Resources/plugIns.js' did not match any files Failed to git add Source/WebCore/Resources/plugIns.js. at /Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply line 448. Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Full output:
http://webkit-queues.appspot.com/results/384844
Antoine Quint
Comment 6
2013-05-04 14:17:54 PDT
Created
attachment 200544
[details]
Patch for landing
WebKit Commit Bot
Comment 7
2013-05-04 14:43:50 PDT
Comment on
attachment 200544
[details]
Patch for landing Clearing flags on attachment: 200544 Committed
r149569
: <
http://trac.webkit.org/changeset/149569
>
WebKit Commit Bot
Comment 8
2013-05-04 14:43:51 PDT
All reviewed patches have been landed. Closing bug.
Anders Carlsson
Comment 9
2013-05-05 10:17:17 PDT
This broke the Windows build: 10>C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release\obj\WebCore\DerivedSources\PlugInsResourcesData.cpp(2) : error C2466: cannot allocate an array of constant size 0 10>C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release\obj\WebCore\DerivedSources\PlugInsResourcesData.cpp(3) : error C2466: cannot allocate an array of constant size 0
Antoine Quint
Comment 10
2013-05-05 22:55:05 PDT
(In reply to
comment #9
)
> This broke the Windows build: > > 10>C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release\obj\WebCore\DerivedSources\PlugInsResourcesData.cpp(2) : error C2466: cannot allocate an array of constant size 0 > 10>C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release\obj\WebCore\DerivedSources\PlugInsResourcesData.cpp(3) : error C2466: cannot allocate an array of constant size 0
The patch for
https://bugs.webkit.org/show_bug.cgi?id=115548
will fix this. I will land this momentarily.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug