I suppose LLInt::Data used some private method/data from StringImpl in the past, but that's not the case anymore. So remove the (bogus) layering violation.
Created attachment 200528 [details]
The commit-queue encountered the following flaky tests while processing attachment 200528 [details]:
fast/frames/crash-remove-iframe-during-object-beforeload.html bug 115322 (author: firstname.lastname@example.org)
The commit-queue is continuing to process your patch.
Comment on attachment 200528 [details]
Clearing flags on attachment: 200528
Committed r149563: <http://trac.webkit.org/changeset/149563>
All reviewed patches have been landed. Closing bug.
Reverted r149563 for reason:
Broke LLInt build.
Committed r149568: <http://trac.webkit.org/changeset/149568>
(In reply to comment #5)
> Reverted r149563 for reason:
> Broke LLInt build.
> Committed r149568: <http://trac.webkit.org/changeset/149568>
Right, there was an ASSERT accessing a private flag, missed that (like EWS). We can change it to use the public getter, will upload a new patch later when I can verify with a debug build.
Can someone svn blame to find out when this interface was added, and when its use was removed?
If the use was truly removed, we can remove the ASSERT. Otherwise, we probably can't remove the interface.