Bug 115575 - [GStreamer] GStreamer log crashes in MediaPlayerPrivateGStreamerBase because of uninitialized category
Summary: [GStreamer] GStreamer log crashes in MediaPlayerPrivateGStreamerBase because ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Xabier Rodríguez Calvar
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-03 14:03 PDT by Xabier Rodríguez Calvar
Modified: 2013-05-03 16:11 PDT (History)
9 users (show)

See Also:


Attachments
Patch (2.28 KB, patch)
2013-05-03 14:06 PDT, Xabier Rodríguez Calvar
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Xabier Rodríguez Calvar 2013-05-03 14:03:15 PDT
[GStreamer] GStreamer log crashes in MediaPlayerPrivateGStreamerBase because of uninitialized category
Comment 1 Xabier Rodríguez Calvar 2013-05-03 14:06:23 PDT
Created attachment 200468 [details]
Patch

Fixes the cadebug category for MediaPlayerPrivatteGStreamerBase.
Comment 2 Philippe Normand 2013-05-03 15:20:43 PDT
Comment on attachment 200468 [details]
Patch

Oh I didn't know the debug category was declared twice. I think it would make more sense to declare it once in the Base header and as extern.
Comment 3 Philippe Normand 2013-05-03 15:21:30 PDT
If that's possible of course :)
Comment 4 Xabier Rodríguez Calvar 2013-05-03 15:44:14 PDT
(In reply to comment #2)
> (From update of attachment 200468 [details])
> Oh I didn't know the debug category was declared twice. I think it would make more sense to declare it once in the Base header and as extern.

The problem of that is the types, and exporting more things like this debug thing is not a very good idea. Base.h file is used in other places. We could create another common .h that we would include in both cpp file, but I think that's overkilling.
Comment 5 Philippe Normand 2013-05-03 15:44:36 PDT
Comment on attachment 200468 [details]
Patch

Oh sorry I misread the patch in the first place. This actually looks good to me :)
Comment 6 WebKit Commit Bot 2013-05-03 16:11:12 PDT
Comment on attachment 200468 [details]
Patch

Clearing flags on attachment: 200468

Committed r149543: <http://trac.webkit.org/changeset/149543>
Comment 7 WebKit Commit Bot 2013-05-03 16:11:15 PDT
All reviewed patches have been landed.  Closing bug.