Bug 115574 - Crash using new WKBundlePageSetHeaderBanner() API to set a banner to null
Summary: Crash using new WKBundlePageSetHeaderBanner() API to set a banner to null
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Beth Dakin
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-05-03 13:55 PDT by Beth Dakin
Modified: 2013-05-04 11:46 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.98 KB, patch)
2013-05-03 13:57 PDT, Beth Dakin 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Beth Dakin 2013-05-03 13:55:39 PDT 
The new WKBundlePageSetHeaderBanner does not correctly handle the null banner case. Patch forthcoming.

<rdar://problem/13798364>
Comment 1 Beth Dakin 2013-05-03 13:57:51 PDT 
Created attachment 200466 [details]
Patch
Comment 2 Benjamin Poulain 2013-05-03 15:58:15 PDT 
Comment on attachment 200466 [details]
Patch

No API tests?
Comment 3 Beth Dakin 2013-05-04 11:44:09 PDT 
(In reply to comment #2)
> (From update of attachment 200466 [details])
> No API tests?

You're right; Sam and I should add API tests for this feature. Up until when Sam added the hit testing stuff to the API (which led to this crash), most of the interesting work was happening down in WebCore and we have been testing it with Internals.setHeaderHeight and Internals.setFooterHeight.
Comment 4 Beth Dakin 2013-05-04 11:46:05 PDT 
http://trac.webkit.org/changeset/149561