This confusing concept is not used for anything.
Created attachment 200470 [details] patch
Attachment 200470 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/dom/ComposedShadowTreeWalker.cpp', u'Source/WebCore/dom/ComposedShadowTreeWalker.h', u'Source/WebCore/dom/ContainerNodeAlgorithms.cpp', u'Source/WebCore/dom/Document.cpp', u'Source/WebCore/dom/Element.cpp', u'Source/WebCore/dom/Element.h', u'Source/WebCore/dom/Element.idl', u'Source/WebCore/dom/ElementShadow.cpp', u'Source/WebCore/dom/ElementShadow.h', u'Source/WebCore/dom/Node.cpp', u'Source/WebCore/dom/Node.h', u'Source/WebCore/dom/ShadowRoot.cpp', u'Source/WebCore/dom/ShadowRoot.h', u'Source/WebCore/dom/TreeScopeAdopter.cpp', u'Source/WebCore/html/shadow/ContentDistributor.cpp', u'Source/WebCore/inspector/InspectorDOMAgent.cpp', u'Source/WebCore/page/FocusController.cpp', u'Source/WebCore/rendering/RenderFileUploadControl.cpp', u'Source/WebCore/svg/SVGTRefElement.cpp', u'Source/WebCore/svg/SVGUseElement.cpp', u'Source/WebCore/testing/Internals.cpp', u'Source/WebCore/testing/Internals.h', u'Source/WebCore/testing/Internals.idl']" exit_code: 1 Source/WebCore/dom/Node.cpp:2069: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/dom/Node.cpp:2072: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/dom/Node.cpp:2073: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 3 in 22 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 200470 [details] patch Attachment 200470 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/388577
Comment on attachment 200470 [details] patch Attachment 200470 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/308578
Created attachment 200501 [details] build fix
Comment on attachment 200501 [details] build fix Attachment 200501 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/391580
Comment on attachment 200501 [details] build fix Attachment 200501 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/337587
Comment on attachment 200501 [details] build fix Attachment 200501 [details] did not pass gtk-ews (gtk): Output: http://webkit-queues.appspot.com/results/388586
Created attachment 200508 [details] another
Comment on attachment 200508 [details] another Attachment 200508 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/337609
Comment on attachment 200508 [details] another Attachment 200508 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/391596
Created attachment 200512 [details] yet another
Created attachment 200513 [details] with test updates
Comment on attachment 200513 [details] with test updates View in context: https://bugs.webkit.org/attachment.cgi?id=200513&action=review r=meh > Source/WebCore/dom/ContainerNodeAlgorithms.cpp:86 > + if (ShadowRoot* root = shadow->shadowRoot()) { This code no longer holds a ref on the ShadowRoot. > Source/WebCore/dom/ContainerNodeAlgorithms.cpp:104 > + if (ShadowRoot* root = shadow->shadowRoot()) Ditto. > Source/WebCore/dom/ElementShadow.cpp:101 > + ASSERT(shadowRoot()); > + if (ShadowRoot* root = shadowRoot()) { Yuck. > Source/WebCore/dom/ElementShadow.cpp:111 > + ASSERT(shadowRoot()); > + if (ShadowRoot* root = shadowRoot()) { Bleh. > Source/WebCore/svg/SVGUseElement.cpp:397 > - if (ShadowRoot* shadowTreeRootElement = shadow()->oldestShadowRoot()) > + if (ShadowRoot* shadowTreeRootElement = shadow()->shadowRoot()) Please fix the whitespace here. Then re-run performance tests.
http://trac.webkit.org/changeset/149549
(In reply to comment #14) > Please fix the whitespace here. Then re-run performance tests. 23% faster in Methanol.