Bug 115570 - Remove concept of younger and older shadow trees
Summary: Remove concept of younger and older shadow trees
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-03 12:22 PDT by Antti Koivisto
Modified: 2013-05-03 20:46 PDT (History)
9 users (show)

See Also:


Attachments
patch (40.07 KB, patch)
2013-05-03 14:49 PDT, Antti Koivisto
eflews.bot: commit-queue-
Details | Formatted Diff | Diff
build fix (41.54 KB, patch)
2013-05-03 15:28 PDT, Antti Koivisto
eflews.bot: commit-queue-
Details | Formatted Diff | Diff
another (41.69 KB, patch)
2013-05-03 16:48 PDT, Antti Koivisto
eflews.bot: commit-queue-
Details | Formatted Diff | Diff
yet another (41.69 KB, patch)
2013-05-03 19:36 PDT, Antti Koivisto
no flags Details | Formatted Diff | Diff
with test updates (46.59 KB, patch)
2013-05-03 20:03 PDT, Antti Koivisto
kling: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2013-05-03 12:22:46 PDT
This confusing concept is not used for anything.
Comment 1 Antti Koivisto 2013-05-03 14:49:43 PDT
Created attachment 200470 [details]
patch
Comment 2 WebKit Commit Bot 2013-05-03 14:51:14 PDT
Attachment 200470 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/dom/ComposedShadowTreeWalker.cpp', u'Source/WebCore/dom/ComposedShadowTreeWalker.h', u'Source/WebCore/dom/ContainerNodeAlgorithms.cpp', u'Source/WebCore/dom/Document.cpp', u'Source/WebCore/dom/Element.cpp', u'Source/WebCore/dom/Element.h', u'Source/WebCore/dom/Element.idl', u'Source/WebCore/dom/ElementShadow.cpp', u'Source/WebCore/dom/ElementShadow.h', u'Source/WebCore/dom/Node.cpp', u'Source/WebCore/dom/Node.h', u'Source/WebCore/dom/ShadowRoot.cpp', u'Source/WebCore/dom/ShadowRoot.h', u'Source/WebCore/dom/TreeScopeAdopter.cpp', u'Source/WebCore/html/shadow/ContentDistributor.cpp', u'Source/WebCore/inspector/InspectorDOMAgent.cpp', u'Source/WebCore/page/FocusController.cpp', u'Source/WebCore/rendering/RenderFileUploadControl.cpp', u'Source/WebCore/svg/SVGTRefElement.cpp', u'Source/WebCore/svg/SVGUseElement.cpp', u'Source/WebCore/testing/Internals.cpp', u'Source/WebCore/testing/Internals.h', u'Source/WebCore/testing/Internals.idl']" exit_code: 1
Source/WebCore/dom/Node.cpp:2069:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/dom/Node.cpp:2072:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/dom/Node.cpp:2073:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 3 in 22 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 EFL EWS Bot 2013-05-03 14:59:19 PDT
Comment on attachment 200470 [details]
patch

Attachment 200470 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/388577
Comment 4 EFL EWS Bot 2013-05-03 15:01:00 PDT
Comment on attachment 200470 [details]
patch

Attachment 200470 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/308578
Comment 5 Antti Koivisto 2013-05-03 15:28:54 PDT
Created attachment 200501 [details]
build fix
Comment 6 EFL EWS Bot 2013-05-03 15:36:14 PDT
Comment on attachment 200501 [details]
build fix

Attachment 200501 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/391580
Comment 7 EFL EWS Bot 2013-05-03 15:38:38 PDT
Comment on attachment 200501 [details]
build fix

Attachment 200501 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/337587
Comment 8 kov's GTK+ EWS bot 2013-05-03 16:00:38 PDT
Comment on attachment 200501 [details]
build fix

Attachment 200501 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/388586
Comment 9 Antti Koivisto 2013-05-03 16:48:55 PDT
Created attachment 200508 [details]
another
Comment 10 EFL EWS Bot 2013-05-03 17:14:26 PDT
Comment on attachment 200508 [details]
another

Attachment 200508 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/337609
Comment 11 EFL EWS Bot 2013-05-03 17:19:17 PDT
Comment on attachment 200508 [details]
another

Attachment 200508 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/391596
Comment 12 Antti Koivisto 2013-05-03 19:36:43 PDT
Created attachment 200512 [details]
yet another
Comment 13 Antti Koivisto 2013-05-03 20:03:56 PDT
Created attachment 200513 [details]
with test updates
Comment 14 Andreas Kling 2013-05-03 20:20:55 PDT
Comment on attachment 200513 [details]
with test updates

View in context: https://bugs.webkit.org/attachment.cgi?id=200513&action=review

r=meh

> Source/WebCore/dom/ContainerNodeAlgorithms.cpp:86
> +        if (ShadowRoot* root = shadow->shadowRoot()) {

This code no longer holds a ref on the ShadowRoot.

> Source/WebCore/dom/ContainerNodeAlgorithms.cpp:104
> +        if (ShadowRoot* root = shadow->shadowRoot())

Ditto.

> Source/WebCore/dom/ElementShadow.cpp:101
> +    ASSERT(shadowRoot());
> +    if (ShadowRoot* root = shadowRoot()) {

Yuck.

> Source/WebCore/dom/ElementShadow.cpp:111
> +    ASSERT(shadowRoot());
> +    if (ShadowRoot* root = shadowRoot()) {

Bleh.

> Source/WebCore/svg/SVGUseElement.cpp:397
> -    if (ShadowRoot* shadowTreeRootElement =  shadow()->oldestShadowRoot())
> +    if (ShadowRoot* shadowTreeRootElement =  shadow()->shadowRoot())

Please fix the whitespace here. Then re-run performance tests.
Comment 15 Antti Koivisto 2013-05-03 20:42:38 PDT
http://trac.webkit.org/changeset/149549
Comment 16 Antti Koivisto 2013-05-03 20:46:24 PDT
(In reply to comment #14)
> Please fix the whitespace here. Then re-run performance tests.

23% faster in Methanol.