Bug 115568 - Simplify the #ifdefs in GraphicsContext3D.h
Summary: Simplify the #ifdefs in GraphicsContext3D.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Martin Robinson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-03 11:58 PDT by Martin Robinson
Modified: 2013-05-03 17:11 PDT (History)
3 users (show)

See Also:


Attachments
Patch (4.71 KB, patch)
2013-05-03 12:03 PDT, Martin Robinson
no flags Details | Formatted Diff | Diff
Move the no-op implementations to GraphicsContext3D.h (5.56 KB, patch)
2013-05-03 12:19 PDT, Martin Robinson
no flags Details | Formatted Diff | Diff
Move the no-op implementations to GraphicsContext3D.h (5.44 KB, patch)
2013-05-03 12:21 PDT, Martin Robinson
benjamin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Robinson 2013-05-03 11:58:47 PDT
The #ifdefs in the header are overwhelming on first glance and befuddling on the second.
Comment 1 Martin Robinson 2013-05-03 12:03:47 PDT
Created attachment 200452 [details]
Patch
Comment 2 Martin Robinson 2013-05-03 12:19:24 PDT
Created attachment 200456 [details]
Move the no-op implementations to GraphicsContext3D.h
Comment 3 Martin Robinson 2013-05-03 12:21:05 PDT
Created attachment 200457 [details]
Move the no-op implementations to GraphicsContext3D.h
Comment 4 Benjamin Poulain 2013-05-03 15:57:10 PDT
Comment on attachment 200457 [details]
Move the no-op implementations to GraphicsContext3D.h

View in context: https://bugs.webkit.org/attachment.cgi?id=200457&action=review

> Source/WebCore/platform/graphics/GraphicsContext3D.cpp:1474
> +#if !PLATFORM(BLACKBERRY) && !PLATFORM(QT) && !PLATFORM(GTK) && !PLATFORM(EFL) && !PLATFORM(MAC)

Isn't this just PLATFORM(WINDOWS)?
Comment 5 Martin Robinson 2013-05-03 17:08:38 PDT
(In reply to comment #4)
> (From update of attachment 200457 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=200457&action=review
> 
> > Source/WebCore/platform/graphics/GraphicsContext3D.cpp:1474
> > +#if !PLATFORM(BLACKBERRY) && !PLATFORM(QT) && !PLATFORM(GTK) && !PLATFORM(EFL) && !PLATFORM(MAC)
> 
> Isn't this just PLATFORM(WINDOWS)?

Sorry. Just saw this comment. Now that Chromium is gone we can probably simplify all these #ifdefs to PLATFORM(WINDOWS). I'll try to submit another patch and put it up against the EWS.
Comment 6 Martin Robinson 2013-05-03 17:11:04 PDT
Committed r149546: <http://trac.webkit.org/changeset/149546>