WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
115552
Make ThreadFunctionInvocation fast-allocated.
https://bugs.webkit.org/show_bug.cgi?id=115552
Summary
Make ThreadFunctionInvocation fast-allocated.
Brent Fulgham
Reported
2013-05-03 09:39:43 PDT
While tracking down some memory allocation problems on Windows (see
Bug 115130
), I noticed that ThreadFunctionInvocation did not use the WTF_MAKE_FAST_ALLOCATED macro. Under Windows, the global replacement of operator new/delete should cause this to be fast allocated, but in practice results in a mismatch (allocating with system new, deallocating with fastFree). Under Gtk/EFL/Qt and perhaps others, ThreadFunctionInvocation is not fast allocated at all. This change simply instructs the system to build ThreadFunctionInvocation as a fast-allocated object, removing the error case under Windows and potentially speeding up memory allocation on other platforms.
Attachments
Patch
(1.09 KB, patch)
2013-05-03 10:05 PDT
,
Brent Fulgham
benjamin
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Brent Fulgham
Comment 1
2013-05-03 10:05:17 PDT
Created
attachment 200430
[details]
Patch
Brent Fulgham
Comment 2
2013-05-03 11:07:51 PDT
Committed
r149524
: <
http://trac.webkit.org/changeset/149524
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug