Bug 115551 - [Qt] Build with --video-track fails because String(AtomicString) is ambiguous
Summary: [Qt] Build with --video-track fails because String(AtomicString) is ambiguous
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: PlatformOnly, Qt
Depends on:
Blocks:
 
Reported: 2013-05-03 09:33 PDT by Brendan Long
Modified: 2013-05-03 16:43 PDT (History)
7 users (show)

See Also:


Attachments
Fix QtWebKitBuild with --video-track (1.80 KB, patch)
2013-05-03 09:35 PDT, Brendan Long
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brendan Long 2013-05-03 09:33:58 PDT
[Qt] Build with --video-track fails because String(AtomicString) is ambiguous
Comment 1 Brendan Long 2013-05-03 09:35:33 PDT
Created attachment 200419 [details]
Fix QtWebKitBuild with --video-track
Comment 2 Brendan Long 2013-05-03 09:37:37 PDT
I'm using qt5-tools (https://github.com/ossy-szeged/qt5-tools) to build Qt5, which may be out of date (2 months since last commit), but this error only shows up if I build with --video-track.

Full error message:

/home/blong/workspace/webkit/Source/WebCore/html/HTMLMediaElement.cpp: In member function 'void WebCore::HTMLMediaElement::configureTextTrackGroup(const WebCore::HTMLMediaElement::TrackGroup&)':
/home/blong/workspace/webkit/Source/WebCore/html/HTMLMediaElement.cpp:3210:142: error: call of overloaded 'String(WTF::AtomicString)' is ambiguous
/home/blong/workspace/webkit/Source/WebCore/html/HTMLMediaElement.cpp:3210:142: note: candidates are:
/home/blong/workspace/webkit/Source/WTF/wtf/text/WTFString.h:431:44: note: WTF::String::String(const QString&)
/home/blong/workspace/webkit/Source/WTF/wtf/text/WTFString.h:98:7: note: WTF::String::String(const WTF::String&)
/home/blong/workspace/webkit/Source/WebCore/html/HTMLMediaElement.cpp:3210:187: error: call of overloaded 'String(WTF::AtomicString)' is ambiguous
/home/blong/workspace/webkit/Source/WebCore/html/HTMLMediaElement.cpp:3210:187: note: candidates are:
/home/blong/workspace/webkit/Source/WTF/wtf/text/WTFString.h:431:44: note: WTF::String::String(const QString&)
/home/blong/workspace/webkit/Source/WTF/wtf/text/WTFString.h:98:7: note: WTF::String::String(const WTF::String&)
Comment 3 Philippe Normand 2013-05-03 11:46:15 PDT
Why is this not working only in Qt? A change to cross-port code to satisfy a single port is suspect to me.
Comment 4 Brendan Long 2013-05-03 12:33:15 PDT
I'm trying to build against a different version of Qt to see if this is just a weird issue with the versions not matching up.
Comment 5 Brendan Long 2013-05-03 15:08:37 PDT
I get this when building against Qt5 master also, so it seems to be a real problem. It seems like making String(AtomicString) not ambiguous would be nice, but I'm not sure if there's a reasonable way to do that.
Comment 6 Benjamin Poulain 2013-05-03 16:20:29 PDT
Comment on attachment 200419 [details]
Fix QtWebKitBuild with --video-track

Not sure why would that constructor would be ambiguous, but the patch looks fine.
Comment 7 WebKit Commit Bot 2013-05-03 16:43:51 PDT
Comment on attachment 200419 [details]
Fix QtWebKitBuild with --video-track

Clearing flags on attachment: 200419

Committed r149544: <http://trac.webkit.org/changeset/149544>
Comment 8 WebKit Commit Bot 2013-05-03 16:43:54 PDT
All reviewed patches have been landed.  Closing bug.