Bug 115551 – [Qt] Build with --video-track fails because String(AtomicString) is ambiguous

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Brendan Long]

[Qt] Build with --video-track fails because String(AtomicString) is ambiguous

[Brendan Long]

Created attachment 200419 [details]
Fix QtWebKitBuild with --video-track

[Brendan Long]

I'm using qt5-tools (https://github.com/ossy-szeged/qt5-tools) to build Qt5, which may be out of date (2 months since last commit), but this error only shows up if I build with --video-track.

Full error message:

/home/blong/workspace/webkit/Source/WebCore/html/HTMLMediaElement.cpp: In member function 'void WebCore::HTMLMediaElement::configureTextTrackGroup(const WebCore::HTMLMediaElement::TrackGroup&)':
/home/blong/workspace/webkit/Source/WebCore/html/HTMLMediaElement.cpp:3210:142: error: call of overloaded 'String(WTF::AtomicString)' is ambiguous
/home/blong/workspace/webkit/Source/WebCore/html/HTMLMediaElement.cpp:3210:142: note: candidates are:
/home/blong/workspace/webkit/Source/WTF/wtf/text/WTFString.h:431:44: note: WTF::String::String(const QString&)
/home/blong/workspace/webkit/Source/WTF/wtf/text/WTFString.h:98:7: note: WTF::String::String(const WTF::String&)
/home/blong/workspace/webkit/Source/WebCore/html/HTMLMediaElement.cpp:3210:187: error: call of overloaded 'String(WTF::AtomicString)' is ambiguous
/home/blong/workspace/webkit/Source/WebCore/html/HTMLMediaElement.cpp:3210:187: note: candidates are:
/home/blong/workspace/webkit/Source/WTF/wtf/text/WTFString.h:431:44: note: WTF::String::String(const QString&)
/home/blong/workspace/webkit/Source/WTF/wtf/text/WTFString.h:98:7: note: WTF::String::String(const WTF::String&)

[Philippe Normand]

Why is this not working only in Qt? A change to cross-port code to satisfy a single port is suspect to me.

[Brendan Long]

I'm trying to build against a different version of Qt to see if this is just a weird issue with the versions not matching up.

[Brendan Long]

I get this when building against Qt5 master also, so it seems to be a real problem. It seems like making String(AtomicString) not ambiguous would be nice, but I'm not sure if there's a reasonable way to do that.

[Benjamin Poulain]

Comment on attachment 200419 [details]
Fix QtWebKitBuild with --video-track

Not sure why would that constructor would be ambiguous, but the patch looks fine.

[WebKit Commit Bot]

Comment on attachment 200419 [details]
Fix QtWebKitBuild with --video-track

Clearing flags on attachment: 200419

Committed r149544: <http://trac.webkit.org/changeset/149544>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.