Bug 115550 – Move pixelSnappedLayoutOverflowRect and maxLayoutOverflow from RenderBox

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Andrei Bucur]

pixelSnappedLayoutOverflowRect and maxLayoutOverflow are used only in special situations so I think they should be moved somewhere else.
pixelSnappedLayoutOverflowRect - called only on RenderView at this moment. There are other places when the overflow rect is pixel snapped but only after the rect is adjusted for writing modes or inflated.
maxLayoutOverflow - used only in RenderTreeAsText; I think it's better to add a static method in RenderTreeAsText.cpp

[Andrei Bucur]

Created attachment 200431 [details]
Patch

[Build Bot]

Comment on attachment 200431 [details]
Patch

Attachment 200431 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/388503

New failing tests:
fast/frames/crash-remove-iframe-during-object-beforeload.html

[Build Bot]

Created attachment 200443 [details]
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-09  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.2

[Andrei Bucur]

(In reply to comment #3)
> Created an attachment (id=200443) [details]
> Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2
> 
> The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
> Bot: webkit-ews-09  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.2

AX stuff strikes again. Not me :(.

[WebKit Commit Bot]

Comment on attachment 200431 [details]
Patch

Clearing flags on attachment: 200431

Committed r149533: <http://trac.webkit.org/changeset/149533>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.