Bug 115550 - Move pixelSnappedLayoutOverflowRect and maxLayoutOverflow from RenderBox
Summary: Move pixelSnappedLayoutOverflowRect and maxLayoutOverflow from RenderBox
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andrei Bucur
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-03 09:29 PDT by Andrei Bucur
Modified: 2013-05-03 13:47 PDT (History)
7 users (show)

See Also:


Attachments
Patch (4.82 KB, patch)
2013-05-03 10:10 PDT, Andrei Bucur
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2 (569.58 KB, application/zip)
2013-05-03 11:19 PDT, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Andrei Bucur 2013-05-03 09:29:49 PDT
pixelSnappedLayoutOverflowRect and maxLayoutOverflow are used only in special situations so I think they should be moved somewhere else.
pixelSnappedLayoutOverflowRect - called only on RenderView at this moment. There are other places when the overflow rect is pixel snapped but only after the rect is adjusted for writing modes or inflated.
maxLayoutOverflow - used only in RenderTreeAsText; I think it's better to add a static method in RenderTreeAsText.cpp
Comment 1 Andrei Bucur 2013-05-03 10:10:04 PDT
Created attachment 200431 [details]
Patch
Comment 2 Build Bot 2013-05-03 11:19:47 PDT
Comment on attachment 200431 [details]
Patch

Attachment 200431 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/388503

New failing tests:
fast/frames/crash-remove-iframe-during-object-beforeload.html
Comment 3 Build Bot 2013-05-03 11:19:48 PDT
Created attachment 200443 [details]
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-09  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.2
Comment 4 Andrei Bucur 2013-05-03 12:16:53 PDT
(In reply to comment #3)
> Created an attachment (id=200443) [details]
> Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2
> 
> The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
> Bot: webkit-ews-09  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.2

AX stuff strikes again. Not me :(.
Comment 5 WebKit Commit Bot 2013-05-03 13:47:10 PDT
Comment on attachment 200431 [details]
Patch

Clearing flags on attachment: 200431

Committed r149533: <http://trac.webkit.org/changeset/149533>
Comment 6 WebKit Commit Bot 2013-05-03 13:47:13 PDT
All reviewed patches have been landed.  Closing bug.