Bug 115543 – Improve the performance of RenderDeprecatedFlexibleBox

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Dave Hyatt]

Make the deprecated flexible box both layout less and repaint less.

[Dave Hyatt]

Created attachment 200384 [details]
Patch

[WebKit Commit Bot]

Attachment 200384 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp', u'Source/WebCore/rendering/RenderDeprecatedFlexibleBox.h']" exit_code: 1
Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp:391:  Omit int when using unsigned  [runtime/unsigned] [1]
Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp:616:  One line control clauses should not use braces.  [whitespace/braces] [4]
Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp:614:  An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp:910:  One line control clauses should not use braces.  [whitespace/braces] [4]
Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp:908:  An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
Total errors found: 5 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Build Bot]

Comment on attachment 200384 [details]
Patch

Attachment 200384 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/382020

New failing tests:
fast/table/recalc-section-first-body-crash-main.html

[Build Bot]

Created attachment 200391 [details]
Archive of layout-test-results from webkit-ews-07 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-07  Port: mac-mountainlion  Platform: Mac OS X 10.8.2

[Build Bot]

Comment on attachment 200384 [details]
Patch

Attachment 200384 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/388396

New failing tests:
fast/table/recalc-section-first-body-crash-main.html

[Build Bot]

Created attachment 200397 [details]
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-09  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.2

[Dave Hyatt]

Created attachment 200418 [details]
Fix the table section layout test failure and clean up the style.

[WebKit Commit Bot]

Attachment 200418 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp', u'Source/WebCore/rendering/RenderDeprecatedFlexibleBox.h']" exit_code: 1
Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp:616:  An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp:911:  An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
Total errors found: 2 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Dave Hyatt]

Created attachment 200426 [details]
Fix style.

[Beth Dakin]

Comment on attachment 200426 [details]
Fix style.

View in context: https://bugs.webkit.org/attachment.cgi?id=200426&action=review

r=me!

> Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp:778
> +    bool clearingFlexibleItemsOverridePass = false;

It seems a little unfortunate to have this wall of state variables show up twice, but I really don't see a way around that.

[Dave Hyatt]

Fixed in r149597.