Bug 115530 - REGRESSION (149389) Main resources converted to downloads are immediately cancelled
Summary: REGRESSION (149389) Main resources converted to downloads are immediately can...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-05-02 14:57 PDT by Brady Eidson
Modified: 2013-05-02 15:22 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2013-05-02 14:57:44 PDT 
REGRESSION (149389) Main resources converted to downloads are immediately cancelled

The NetworkResourceLoader needs to know its handle should not be cancelled.

In radar as <rdar://problem/13795795>
Comment 1 Brady Eidson 2013-05-02 15:11:55 PDT 
I tried a patch that clears m_handle and keeps track of the ref()/deref() self state via a new bool, but because of the threading involved that ran into bizarre problems we don't have time to explore right now.

Prepping a patch that is probably a little worse but definitely works.
Comment 2 Brady Eidson 2013-05-02 15:21:09 PDT 
Alexey reviewed this patch over my shoulder.  Landing soon.
Comment 3 Brady Eidson 2013-05-02 15:22:42 PDT 
http://trac.webkit.org/changeset/149499