RESOLVED FIXED 115526
Shadow DOM removal: Make SelectorChecker non-generic
https://bugs.webkit.org/show_bug.cgi?id=115526
Summary Shadow DOM removal: Make SelectorChecker non-generic
Antti Koivisto
Reported 2013-05-02 14:26:05 PDT
Core SelectorChecker methods are currently templated to support distributed shadow trees. Without shadow DOM distribution support this is no longer needed.
Attachments
patch (30.56 KB, patch)
2013-05-02 14:37 PDT, Antti Koivisto
kling: review+
Antti Koivisto
Comment 1 2013-05-02 14:37:51 PDT
Andreas Kling
Comment 2 2013-05-02 14:44:51 PDT
Comment on attachment 200335 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=200335&action=review r=me > Source/WebCore/css/SelectorChecker.cpp:65 > +static inline bool isFirstChildElement(Element* element) I'd make this take a const Element*. > Source/WebCore/css/SelectorChecker.cpp:70 > +static inline bool isLastChildElement(Element* element) Ditto. > Source/WebCore/css/SelectorChecker.cpp:75 > +static inline bool isFirstOfType(Element* element, const QualifiedName& type) Ditto. > Source/WebCore/css/SelectorChecker.cpp:84 > +static inline bool isLastOfType(Element* element, const QualifiedName& type) Ditto. > Source/WebCore/css/SelectorChecker.cpp:93 > +static inline int countElementsBefore(Element* element) Ditto. > Source/WebCore/css/SelectorChecker.cpp:107 > +static inline int countElementsOfTypeBefore(Element* element, const QualifiedName& type) Ditto. > Source/WebCore/css/SelectorChecker.cpp:117 > +static inline int countElementsAfter(Element* element) Ditto. > Source/WebCore/css/SelectorChecker.cpp:125 > +static inline int countElementsOfTypeAfter(Element* element, const QualifiedName& type) Ditto. > Source/WebCore/css/SiblingTraversalStrategies.h:1 > +// Remove this file. wat
Antti Koivisto
Comment 3 2013-05-02 15:13:46 PDT
Note You need to log in before you can comment on or make changes to this bug.