Bug 115526 - Shadow DOM removal: Make SelectorChecker non-generic
Summary: Shadow DOM removal: Make SelectorChecker non-generic
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-02 14:26 PDT by Antti Koivisto
Modified: 2013-05-02 15:13 PDT (History)
7 users (show)

See Also:

Attachments
patch (30.56 KB, patch)
2013-05-02 14:37 PDT, Antti Koivisto 		kling: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2013-05-02 14:26:05 PDT 
Core SelectorChecker methods are currently templated to support distributed shadow trees. Without shadow DOM distribution support this is no longer needed.
Comment 1 Antti Koivisto 2013-05-02 14:37:51 PDT 
Created attachment 200335 [details]
patch
Comment 2 Andreas Kling 2013-05-02 14:44:51 PDT 
Comment on attachment 200335 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=200335&action=review

r=me

> Source/WebCore/css/SelectorChecker.cpp:65
> +static inline bool isFirstChildElement(Element* element)

I'd make this take a const Element*.

> Source/WebCore/css/SelectorChecker.cpp:70
> +static inline bool isLastChildElement(Element* element)

Ditto.

> Source/WebCore/css/SelectorChecker.cpp:75
> +static inline bool isFirstOfType(Element* element, const QualifiedName& type)

Ditto.

> Source/WebCore/css/SelectorChecker.cpp:84
> +static inline bool isLastOfType(Element* element, const QualifiedName& type)

Ditto.

> Source/WebCore/css/SelectorChecker.cpp:93
> +static inline int countElementsBefore(Element* element)

Ditto.

> Source/WebCore/css/SelectorChecker.cpp:107
> +static inline int countElementsOfTypeBefore(Element* element, const QualifiedName& type)

Ditto.

> Source/WebCore/css/SelectorChecker.cpp:117
> +static inline int countElementsAfter(Element* element)

Ditto.

> Source/WebCore/css/SelectorChecker.cpp:125
> +static inline int countElementsOfTypeAfter(Element* element, const QualifiedName& type)

Ditto.

> Source/WebCore/css/SiblingTraversalStrategies.h:1
> +// Remove this file.

wat
Comment 3 Antti Koivisto 2013-05-02 15:13:46 PDT 
http://trac.webkit.org/changeset/149498