Bug 115522 - Fix potential bug in lookup logic
Summary: Fix potential bug in lookup logic
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Oliver Hunt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-02 12:27 PDT by Oliver Hunt
Modified: 2013-05-02 13:58 PDT (History)
0 users

See Also:


Attachments
Patch (2.80 KB, patch)
2013-05-02 12:32 PDT, Oliver Hunt
no flags Details | Formatted Diff | Diff
Patch (2.82 KB, patch)
2013-05-02 12:36 PDT, Oliver Hunt
mhahnenberg: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Oliver Hunt 2013-05-02 12:27:14 PDT
Fix potential bug in lookup logic
Comment 1 Oliver Hunt 2013-05-02 12:32:09 PDT
Created attachment 200329 [details]
Patch
Comment 2 Filip Pizlo 2013-05-02 12:33:32 PDT
Comment on attachment 200329 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=200329&action=review

> Source/JavaScriptCore/ChangeLog:12
> +        in BytecodeGenerator actually limits itself to scopes that
> +        static.

What are scopes that static?
Comment 3 Oliver Hunt 2013-05-02 12:35:18 PDT
<rdar://problem/13795064>
Comment 4 Oliver Hunt 2013-05-02 12:36:38 PDT
Created attachment 200330 [details]
Patch
Comment 5 Mark Hahnenberg 2013-05-02 13:56:48 PDT
Comment on attachment 200330 [details]
Patch

r=me
Comment 6 Oliver Hunt 2013-05-02 13:58:42 PDT
Committed r149496: <http://trac.webkit.org/changeset/149496>