Bug 115520 - [WK2] Non-ASCII downloaded file names are garbled when using NetworkProcess
Summary: [WK2] Non-ASCII downloaded file names are garbled when using NetworkProcess
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-05-02 11:36 PDT by Alexey Proskuryakov
Modified: 2013-05-02 12:25 PDT (History)
1 user (show)

See Also:

Attachments
proposed fix (9.15 KB, patch)
2013-05-02 11:46 PDT, Alexey Proskuryakov 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2013-05-02 11:36:44 PDT 
responseContentDispositionEncodingFallbackArray is not sent over IPC.

<rdar://problem/13740375>
Comment 1 Alexey Proskuryakov 2013-05-02 11:46:54 PDT 
Created attachment 200325 [details]
proposed fix
Comment 2 Darin Adler 2013-05-02 11:52:06 PDT 
Comment on attachment 200325 [details]
proposed fix

View in context: https://bugs.webkit.org/attachment.cgi?id=200325&action=review

> Source/WebCore/platform/network/ResourceRequestBase.h:114
> +        const Vector<String> responseContentDispositionEncodingFallbackArray() const { return m_responseContentDispositionEncodingFallbackArray; }

The const here in const Vector<String> is not needed or helpful. Unless maybe you wanted to return const& to avoid copying.

> Source/WebKit2/Shared/mac/WebCoreArgumentCodersMac.mm:63
> +    encoder << resourceRequest.responseContentDispositionEncodingFallbackArray();

Do we have to bump a version number when we do things like this?
Comment 3 Alexey Proskuryakov 2013-05-02 11:59:55 PDT 
> Unless maybe you wanted to return const& to avoid copying.

Oops, yes.

> Do we have to bump a version number when we do things like this?

Not here, this serialization is for IPC only, and is not persistent.
Comment 4 Alexey Proskuryakov 2013-05-02 12:25:53 PDT 
Committed <http://trac.webkit.org/r149491>.