RESOLVED FIXED115519
Make BloomFilter Fast-Allocated 
https://bugs.webkit.org/show_bug.cgi?id=115519
Summary Make BloomFilter Fast-Allocated
Brent Fulgham
Reported 2013-05-02 11:31:23 PDT
While tracking down some memory allocation problems on Windows (see Bug 115130), I noticed that BloomFilter did not use the WTF_MAKE_FAST_ALLOCATED macro. Under Windows, the global replacement of operator new/delete should cause this to be fast allocated, but in practice results in a mismatch (allocating with system new, deallocating with fastFree). Under Gtk/EFL/Qt and perhaps others, BloomFilter is not fast allocated at all. This change simply instructs the system to build BloomFilter as a fast-allocated object, removing the error case under Windows and potentially speeding up memory allocation on other platforms.
Attachments
Patch (1.03 KB, patch)
2013-05-02 11:33 PDT, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Patch (1.09 KB, patch)
2013-05-03 09:49 PDT, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2013-05-02 11:33:20 PDT
Created attachment 200323 [details] Patch
Geoffrey Garen
Comment 2 2013-05-02 12:05:45 PDT
Comment on attachment 200323 [details] Patch r=me
Brent Fulgham
Comment 3 2013-05-02 13:47:56 PDT
Committed r149493: <http://trac.webkit.org/changeset/149493>
Brent Fulgham
Comment 4 2013-05-03 09:49:17 PDT
Reopening to attach new patch.
Brent Fulgham
Comment 5 2013-05-03 09:49:19 PDT
Created attachment 200425 [details] Patch
Benjamin Poulain
Comment 6 2013-05-03 09:57:34 PDT
Comment on attachment 200425 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=200425&action=review > Source/WTF/ChangeLog:4 > + https://bugs.webkit.org/show_bug.cgi?id=115519 Wrong bug URL. That bug was about BloomFilter.
Brent Fulgham
Comment 7 2013-05-03 10:06:02 PDT
Whoops. Attached to wrong bug. Nothing to see here...
Note You need to log in before you can comment on or make changes to this bug.