Some of the APIs documentation wrong in ewk_settings APIs. 1)EAPI const char *ewk_settings_web_database_path_get(void); * By default, the value is @c ~/.webkit 2)EAPI void ewk_settings_local_storage_path_set(const char* path); EAPI const char* ewk_settings_local_storage_path_get(void); * By default, the value is @c ~/.webkit 3)EAPI const char *ewk_settings_application_cache_path_get(void); * By default, the path is @c NULL, indicating that the feature is disabled.
Created attachment 200302 [details] Patch
(In reply to comment #1) > Created an attachment (id=200302) [details] > Patch Please comment if any other documentation to be corrected with this bug.
LGTM, thanks!
Comment on attachment 200302 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=200302&action=review > Source/WebKit/efl/ewk/ewk_settings.h:60 > + * By default, the value is @c $HOME/.cache/WebKitEfl/Databases Doesn't "/" mean home directory ? It looks "~/" is more simple than $HOME. > Source/WebKit/efl/ewk/ewk_settings.h:-200 > - * By default, the path is @c NULL, indicating that the feature is disabled. Once the path is set, the feature is enabled >> Once the path is set, the feature is enabled and the path cannot be changed Why do you remove existing comment ? Isn't this comment still valid ?
(In reply to comment #4) > (From update of attachment 200302 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=200302&action=review > > > Source/WebKit/efl/ewk/ewk_settings.h:60 > > + * By default, the value is @c $HOME/.cache/WebKitEfl/Databases > > Doesn't "/" mean home directory ? It looks "~/" is more simple than $HOME. I will correct this to ~/ > > > Source/WebKit/efl/ewk/ewk_settings.h:-200 > > - * By default, the path is @c NULL, indicating that the feature is disabled. Once the path is set, the feature is enabled > > >> Once the path is set, the feature is enabled and the path cannot be changed > > Why do you remove existing comment ? Isn't this comment still valid ? I will add this "Once the path is set, the feature is enabled and the path cannot be changed"
Created attachment 201034 [details] Patch Updated patch
Comment on attachment 201034 [details] Patch Clearing flags on attachment: 201034 Committed r149719: <http://trac.webkit.org/changeset/149719>
All reviewed patches have been landed. Closing bug.