Bug 115502 - FastMalloc.cpp should use system defined page size instead of literal constant
Summary: FastMalloc.cpp should use system defined page size instead of literal constant
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Michael Saboff
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-01 18:02 PDT by Michael Saboff
Modified: 2013-05-01 18:22 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.99 KB, patch)
2013-05-01 18:09 PDT, Michael Saboff 		ggaren: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Saboff 2013-05-01 18:02:09 PDT 
FastMalloc.cpp uses kPageShift to derive page size of the OS for various data structures.  Currently it is set at 12:
static const size_t kPageShift  = 12

Instead FastMalloc.cpp should use a system define.  For Mac this is PAGE_SHIFT (and possibly other OS'es as well).
Comment 1 Michael Saboff 2013-05-01 18:09:43 PDT 
Created attachment 200293 [details]
Patch

Only added Mac specific use of system define.  Other platform partners can add appropriate values.
Comment 2 Geoffrey Garen 2013-05-01 18:15:08 PDT 
Comment on attachment 200293 [details]
Patch

r=me
Comment 3 Michael Saboff 2013-05-01 18:22:03 PDT 
Committed r149472: <http://trac.webkit.org/changeset/149472>