Bug 115499 – AX: aria-checked not exposed correctly on menuitemcheckbox or menuitemradio roles

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[James Craig]

AX: aria-checked not exposed correctly on menuitemcheckbox or menuitemradio roles

https://dvcs.w3.org/hg/pfwg/raw-file/default/ARIA/1.0/tests/test-files/_/777.htm

[Radar WebKit Bug Importer]

<rdar://problem/13787768>

[James Craig]

Expected AXMenuItemMarkChar: ✓

[chris fleizach]

Created attachment 200390 [details]
patch

[Build Bot]

Comment on attachment 200390 [details]
patch

Attachment 200390 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/388385

New failing tests:
platform/mac/accessibility/aria-menuitem-checked-value.html

[Build Bot]

Created attachment 200393 [details]
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-12  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.2

[chris fleizach]

Created attachment 200416 [details]
patch

[chris fleizach]

Comment on attachment 200416 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=200416&action=review

> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:2301
> +        return (m_object->isChecked()) ? @"â" : nil;

this is the checkmark that the Mac returns for selected menu items

[Tim Horton]

Comment on attachment 200416 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=200416&action=review

>> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:2301
>> +        return (m_object->isChecked()) ? @"â" : nil;
> 
> this is the checkmark that the Mac returns for selected menu items

Can we use [NSString stringWithUTF8String:"\xe2\x9c\x93"] instead? My understanding is that using unicode in objc string literals is a Bad Idea regardless of file encoding. Alexey or Dan would know better though.

[Alexey Proskuryakov]

IIRC this works just fine starting with Lion (as long as source file encoding is set to UTF-8 in Xcode project file).

[chris fleizach]

Created attachment 200519 [details]
patch

[chris fleizach]

Created attachment 200520 [details]
patch

[WebKit Commit Bot]

Comment on attachment 200520 [details]
patch

Clearing flags on attachment: 200520

Committed r149581: <http://trac.webkit.org/changeset/149581>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.