Bug 115442 - Page::pageCount() is inaccurate when we allow the first paint in App Mode
Summary: Page::pageCount() is inaccurate when we allow the first paint in App Mode
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Beth Dakin
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-04-30 12:25 PDT by Beth Dakin
Modified: 2013-04-30 12:53 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.58 KB, patch)
2013-04-30 12:30 PDT, Beth Dakin 		hyatt: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Beth Dakin 2013-04-30 12:25:46 PDT 
Page::pageCount() is inaccurate when we allow the first paint in App Mode, which happens when Document::setVisualUpdatesAllowed(true) is called. It should be accurate.

After layout is updated, the page count should be accurate, but it is not for paginated content that contains images because auto-height images are given a layout height of 0 after the first pass. They require a second pass to get the right height. They shouldn't.

<rdar://problem/13758445>
Comment 1 Beth Dakin 2013-04-30 12:30:36 PDT 
Created attachment 200141 [details]
Patch
Comment 2 Dave Hyatt 2013-04-30 12:52:23 PDT 
Comment on attachment 200141 [details]
Patch

r=me
Comment 3 Beth Dakin 2013-04-30 12:53:42 PDT 
Thanks, Dave! http://trac.webkit.org/changeset/149393