Bug 115432 - REGRESSION(r140907): Incorrect baseline on cells after updating vertical-align
Summary: REGRESSION(r140907): Incorrect baseline on cells after updating vertical-align
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tables (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Robert Hogan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-30 11:08 PDT by Robert Hogan
Modified: 2013-05-04 00:45 PDT (History)
4 users (show)

See Also:

Attachments
Reduction (1.12 KB, text/html)
2013-04-30 11:09 PDT, Robert Hogan 		no flags Details
Patch (4.77 KB, patch)
2013-04-30 12:54 PDT, Robert Hogan 		jchaffraix: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Hogan 2013-04-30 11:08:20 PDT 
This is the webkit counterpart to https://code.google.com/p/chromium/issues/detail?id=227017
Comment 1 Robert Hogan 2013-04-30 11:09:28 PDT 
Created attachment 200133 [details]
Reduction
Comment 2 Robert Hogan 2013-04-30 12:54:10 PDT 
Created attachment 200142 [details]
Patch
Comment 3 Julien Chaffraix 2013-05-02 11:20:04 PDT 
Comment on attachment 200142 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=200142&action=review

> Source/WebCore/rendering/RenderTableCell.cpp:408
> +    if (oldStyle && style()->verticalAlign() != oldStyle->verticalAlign())

Let's add a comment about why this is required.
Comment 4 Robert Hogan 2013-05-04 00:45:20 PDT 
Committed r149553: <http://trac.webkit.org/changeset/149553>