WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
115425
String::isolatedCopy() can avoid a copy if the original is a temporary
https://bugs.webkit.org/show_bug.cgi?id=115425
Summary
String::isolatedCopy() can avoid a copy if the original is a temporary
Anders Carlsson
Reported
2013-04-30 09:20:40 PDT
String::isolatedCopy() can avoid a copy if the original is a temporary
Attachments
Patch
(3.76 KB, patch)
2013-04-30 09:25 PDT
,
Anders Carlsson
darin
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Anders Carlsson
Comment 1
2013-04-30 09:25:31 PDT
Created
attachment 200123
[details]
Patch
WebKit Commit Bot
Comment 2
2013-04-30 09:27:19 PDT
Attachment 200123
[details]
did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/Compiler.h', u'Source/WTF/wtf/text/WTFString.cpp', u'Source/WTF/wtf/text/WTFString.h']" exit_code: 1 Source/WTF/wtf/text/WTFString.cpp:659: This { should be at the end of the previous line [whitespace/braces] [4] Source/WTF/wtf/text/WTFString.cpp:665: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] Source/WTF/wtf/text/WTFString.cpp:666: This { should be at the end of the previous line [whitespace/braces] [4] Total errors found: 3 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Anders Carlsson
Comment 3
2013-04-30 09:30:44 PDT
Committed
r149372
: <
http://trac.webkit.org/changeset/149372
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug