Bug 115425 - String::isolatedCopy() can avoid a copy if the original is a temporary
Summary: String::isolatedCopy() can avoid a copy if the original is a temporary
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-30 09:20 PDT by Anders Carlsson
Modified: 2013-04-30 09:30 PDT (History)
3 users (show)

See Also:

Attachments
Patch (3.76 KB, patch)
2013-04-30 09:25 PDT, Anders Carlsson 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2013-04-30 09:20:40 PDT 
String::isolatedCopy() can avoid a copy if the original is a temporary
Comment 1 Anders Carlsson 2013-04-30 09:25:31 PDT 
Created attachment 200123 [details]
Patch
Comment 2 WebKit Commit Bot 2013-04-30 09:27:19 PDT 
Attachment 200123 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/Compiler.h', u'Source/WTF/wtf/text/WTFString.cpp', u'Source/WTF/wtf/text/WTFString.h']" exit_code: 1
Source/WTF/wtf/text/WTFString.cpp:659:  This { should be at the end of the previous line  [whitespace/braces] [4]
Source/WTF/wtf/text/WTFString.cpp:665:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Source/WTF/wtf/text/WTFString.cpp:666:  This { should be at the end of the previous line  [whitespace/braces] [4]
Total errors found: 3 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Anders Carlsson 2013-04-30 09:30:44 PDT 
Committed r149372: <http://trac.webkit.org/changeset/149372>