Bug 115401 - [CSS Grid Layout] Fix handling of 'inherit' and 'initial' for grid lines
Summary: [CSS Grid Layout] Fix handling of 'inherit' and 'initial' for grid lines
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sergio Villar Senin
URL:
Keywords: BlinkMergeCandidate
Depends on:
Blocks: 60731
  Show dependency tree / graph
 
Reported: 2013-04-30 00:55 PDT by Ryosuke Niwa
Modified: 2013-11-07 02:44 PST (History)
20 users (show)

See Also:

Attachments
Patch (22.96 KB, patch)
2013-11-06 04:47 PST, Sergio Villar Senin 		no flags Details | Formatted Diff | Diff
Patch (23.05 KB, patch)
2013-11-06 07:49 PST, Sergio Villar Senin 		kling: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2013-04-30 00:55:09 PDT 
We should consider back porting https://chromium.googlesource.com/chromium/blink/+/5d3509453888658290265b2ca96b569862ea396b

Fix handling of 'inherit' and 'initial' for grid lines

'initial' and 'inherit' are always allowed values for CSS properties.
As the CSSParser handles them automatically, those 2 values were never
taken care of in StyleResolver, leading to ASSERTs triggering.

While touching this code, renamed the RenderStyle grid line accessors
as it shouldn't ambiguous to whom they apply.

BUG=234198
TESTS=fast/css-grid-layout/grid-item-column-row-get-set.html
      fast/css-grid-layout/grid-item-end-after-get-set.html
      fast/css-grid-layout/grid-item-start-before-get-set.html

Review URL: https://chromiumcodereview.appspot.com/14493016
Comment 1 Sergio Villar Senin 2013-11-06 04:47:17 PST 
Created attachment 216165 [details]
Patch
Comment 2 EFL EWS Bot 2013-11-06 04:58:12 PST 
Comment on attachment 216165 [details]
Patch

Attachment 216165 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/21308195
Comment 3 EFL EWS Bot 2013-11-06 05:02:52 PST 
Comment on attachment 216165 [details]
Patch

Attachment 216165 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/21788099
Comment 4 Build Bot 2013-11-06 05:21:16 PST 
Comment on attachment 216165 [details]
Patch

Attachment 216165 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/21858084
Comment 5 Build Bot 2013-11-06 05:55:51 PST 
Comment on attachment 216165 [details]
Patch

Attachment 216165 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/21738083
Comment 6 Build Bot 2013-11-06 07:14:41 PST 
Comment on attachment 216165 [details]
Patch

Attachment 216165 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/21768096
Comment 7 Sergio Villar Senin 2013-11-06 07:49:05 PST 
Created attachment 216175 [details]
Patch
Comment 8 Sergio Villar Senin 2013-11-07 02:44:05 PST 
Committed r158838: <http://trac.webkit.org/changeset/158838>