There is one existing command, suggest-nominations, that analyzes commit logs. There are two additional commands proposed [1][2] that also need to analyze commit logs. In order to factor out common shared functionality, the commit log analysis functionality should be placed in an abstract base class that subclass Command, let's call this AbstractCommitLogCommand.
(In reply to comment #0) > There is one existing command, suggest-nominations, that analyzes commit logs. There are two additional commands proposed [1][2] that also need to analyze commit logs. In order to factor out common shared functionality, the commit log analysis functionality should be placed in an abstract base class that subclass Command, let's call this AbstractCommitLogCommand. [1] https://bugs.webkit.org/show_bug.cgi?id=115387 [2] https://bugs.webkit.org/show_bug.cgi?id=115388
Created attachment 200202 [details] Patch
Comment on attachment 200202 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=200202&action=review > Tools/Scripts/webkitpy/tool/commands/suggestnominations.py:62 > + options = sorted(options, lambda a, b: cmp(a._long_opts, b._long_opts)) I would prefer named arguments with sorted().
Created attachment 200297 [details] Patch for landing
(In reply to comment #3) > (From update of attachment 200202 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=200202&action=review > > > Tools/Scripts/webkitpy/tool/commands/suggestnominations.py:62 > > + options = sorted(options, lambda a, b: cmp(a._long_opts, b._long_opts)) > > I would prefer named arguments with sorted(). Fixed.
Comment on attachment 200297 [details] Patch for landing Clearing flags on attachment: 200297 Committed r149480: <http://trac.webkit.org/changeset/149480>
All reviewed patches have been landed. Closing bug.