Bug 115389 - It should be an error to use adoptPtr with RefCounted subclasses
Summary: It should be an error to use adoptPtr with RefCounted subclasses
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-29 17:24 PDT by Anders Carlsson
Modified: 2013-04-29 17:45 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.59 KB, patch)
2013-04-29 17:25 PDT, Anders Carlsson 		benjamin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2013-04-29 17:24:28 PDT 
It should be an error to use adoptPtr with RefCounted subclasses
Comment 1 Anders Carlsson 2013-04-29 17:25:10 PDT 
Created attachment 200063 [details]
Patch
Comment 2 Benjamin Poulain 2013-04-29 17:34:53 PDT 
Comment on attachment 200063 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=200063&action=review

I loooove this. Great idea.

> Source/WTF/wtf/PassOwnPtr.h:151
> +        COMPILE_ASSERT(!(IsSubclass<T, RefCounted<T> >::value), DoNotUseAdoptPtrWithRefCounted);
> +        COMPILE_ASSERT(!(IsSubclass<T, ThreadSafeRefCounted<T> >::value), DoNotUseAdoptPtrWithThreadSafeRefCounted);

+RefCountedBase
Comment 3 Anders Carlsson 2013-04-29 17:38:58 PDT 
(In reply to comment #2)
> (From update of attachment 200063 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=200063&action=review
> 
> I loooove this. Great idea.
> 
> > Source/WTF/wtf/PassOwnPtr.h:151
> > +        COMPILE_ASSERT(!(IsSubclass<T, RefCounted<T> >::value), DoNotUseAdoptPtrWithRefCounted);
> > +        COMPILE_ASSERT(!(IsSubclass<T, ThreadSafeRefCounted<T> >::value), DoNotUseAdoptPtrWithThreadSafeRefCounted);
> 
> +RefCountedBase

I’ll use ThreadSafeRefCountedBase and RefCountedBase instead.
Comment 4 Anders Carlsson 2013-04-29 17:45:18 PDT 
Committed r149341: <http://trac.webkit.org/changeset/149341>