RESOLVED FIXED 115380
Replace "Optional" extended attribute by proper Web IDL "optional" keyword 
https://bugs.webkit.org/show_bug.cgi?id=115380
Summary Replace "Optional" extended attribute by proper Web IDL "optional" keyword
Chris Dumez
Reported 2013-04-29 15:53:36 PDT
WebKit uses a Webkit-specific "Optional" extended attribute for optional parameters in IDL files. However, standard Web IDL uses the "optional" keyword the do the same. We should follow the standard as much as possible use switch to using the optional keyword in our IDL files and fix the bindings generator accordingly.
Attachments
Patch (299.17 KB, patch)
2013-04-29 23:44 PDT, Chris Dumez 		haraken: review+
eflews.bot: commit-queue-
DetailsFormatted DiffDiff
Patch for landing (302.26 KB, patch)
2013-04-30 00:14 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2013-04-29 23:44:10 PDT
Created attachment 200083 [details] Patch
Kentaro Hara
Comment 2 2013-04-29 23:52:11 PDT
Comment on attachment 200083 [details] Patch Looks OK.
EFL EWS Bot
Comment 3 2013-04-29 23:56:12 PDT
Comment on attachment 200083 [details] Patch Attachment 200083 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/195000
Chris Dumez
Comment 4 2013-04-30 00:14:19 PDT
Created attachment 200085 [details] Patch for landing Update WK2 IDLs.
WebKit Commit Bot
Comment 5 2013-04-30 01:31:42 PDT
Comment on attachment 200085 [details] Patch for landing Clearing flags on attachment: 200085 Committed r149356: <http://trac.webkit.org/changeset/149356>
WebKit Commit Bot
Comment 6 2013-04-30 01:31:45 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.