Bug 115380 - Replace "Optional" extended attribute by proper Web IDL "optional" keyword
Summary: Replace "Optional" extended attribute by proper Web IDL "optional" keyword
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL: http://dev.w3.org/2006/webapi/WebIDL/...
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-29 15:53 PDT by Chris Dumez
Modified: 2013-04-30 01:31 PDT (History)
7 users (show)

See Also:


Attachments
Patch (299.17 KB, patch)
2013-04-29 23:44 PDT, Chris Dumez
haraken: review+
eflews.bot: commit-queue-
Details | Formatted Diff | Diff
Patch for landing (302.26 KB, patch)
2013-04-30 00:14 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2013-04-29 15:53:36 PDT
WebKit uses a Webkit-specific "Optional" extended attribute for optional parameters in IDL files. However, standard Web IDL uses the "optional" keyword the do the same.

We should follow the standard as much as possible use switch to using the optional keyword in our IDL files and fix the bindings generator accordingly.
Comment 1 Chris Dumez 2013-04-29 23:44:10 PDT
Created attachment 200083 [details]
Patch
Comment 2 Kentaro Hara 2013-04-29 23:52:11 PDT
Comment on attachment 200083 [details]
Patch

Looks OK.
Comment 3 EFL EWS Bot 2013-04-29 23:56:12 PDT
Comment on attachment 200083 [details]
Patch

Attachment 200083 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/195000
Comment 4 Chris Dumez 2013-04-30 00:14:19 PDT
Created attachment 200085 [details]
Patch for landing

Update WK2 IDLs.
Comment 5 WebKit Commit Bot 2013-04-30 01:31:42 PDT
Comment on attachment 200085 [details]
Patch for landing

Clearing flags on attachment: 200085

Committed r149356: <http://trac.webkit.org/changeset/149356>
Comment 6 WebKit Commit Bot 2013-04-30 01:31:45 PDT
All reviewed patches have been landed.  Closing bug.