Bug 115375 - [Windows, WinCairo] Remove Link And Includes for Pthreads from JavaScriptCore
Summary: [Windows, WinCairo] Remove Link And Includes for Pthreads from JavaScriptCore
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords:
Depends on: 114864
Blocks:
  Show dependency treegraph
 
Reported: 2013-04-29 13:56 PDT by Brent Fulgham
Modified: 2013-04-29 15:07 PDT (History)
0 users

See Also:


Attachments
Patch (7.70 KB, patch)
2013-04-29 14:54 PDT, Brent Fulgham
thorton: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2013-04-29 13:56:43 PDT
Update the build rules for the Windows/WinCairo builds to no longer reference or link to pthreadsVC2.dll.  Nothing in JavaScriptCore uses the pthreads library on the Windows port, so linking to the library serves no purpose.
Comment 1 Brent Fulgham 2013-04-29 14:39:26 PDT
There are a handful of remaining references.  This update attempts to clear out that last couple of them.
Comment 2 Brent Fulgham 2013-04-29 14:54:09 PDT
Created attachment 200049 [details]
Patch
Comment 3 Brent Fulgham 2013-04-29 14:54:55 PDT
I don't know why Visual Studio does weird things like change the last line of the file; I can't easily prevent that when generating the patch. :-(
Comment 4 Brent Fulgham 2013-04-29 15:07:41 PDT
Committed r149320: <http://trac.webkit.org/changeset/149320>