Bug 115365 - Add a StorageSyncManager::dispatch helper function
Summary: Add a StorageSyncManager::dispatch helper function
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-29 11:16 PDT by Anders Carlsson
Modified: 2013-04-29 11:25 PDT (History)
1 user (show)

See Also:

Attachments
Patch (3.49 KB, patch)
2013-04-29 11:19 PDT, Anders Carlsson 		kling: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2013-04-29 11:16:54 PDT 
Add a StorageSyncManager::dispatch helper function
Comment 1 Anders Carlsson 2013-04-29 11:19:51 PDT 
Created attachment 200030 [details]
Patch
Comment 2 WebKit Commit Bot 2013-04-29 11:22:29 PDT 
Attachment 200030 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/storage/StorageSyncManager.cpp', u'Source/WebCore/storage/StorageSyncManager.h']" exit_code: 1
Source/WebCore/storage/StorageSyncManager.h:49:  Extra space before ( in function call  [whitespace/parens] [4]
Source/WebCore/storage/StorageSyncManager.cpp:74:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 2 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Andreas Kling 2013-04-29 11:23:53 PDT 
Comment on attachment 200030 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=200030&action=review

r=me

> Source/WebCore/storage/StorageSyncManager.cpp:77
> +    ASSERT(m_thread);

No "if (m_thread)" this time?
Comment 4 Anders Carlsson 2013-04-29 11:25:28 PDT 
Committed r149300: <http://trac.webkit.org/changeset/149300>