WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
115365
Add a StorageSyncManager::dispatch helper function
https://bugs.webkit.org/show_bug.cgi?id=115365
Summary
Add a StorageSyncManager::dispatch helper function
Anders Carlsson
Reported
2013-04-29 11:16:54 PDT
Add a StorageSyncManager::dispatch helper function
Attachments
Patch
(3.49 KB, patch)
2013-04-29 11:19 PDT
,
Anders Carlsson
kling
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Anders Carlsson
Comment 1
2013-04-29 11:19:51 PDT
Created
attachment 200030
[details]
Patch
WebKit Commit Bot
Comment 2
2013-04-29 11:22:29 PDT
Attachment 200030
[details]
did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/storage/StorageSyncManager.cpp', u'Source/WebCore/storage/StorageSyncManager.h']" exit_code: 1 Source/WebCore/storage/StorageSyncManager.h:49: Extra space before ( in function call [whitespace/parens] [4] Source/WebCore/storage/StorageSyncManager.cpp:74: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 2 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Andreas Kling
Comment 3
2013-04-29 11:23:53 PDT
Comment on
attachment 200030
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=200030&action=review
r=me
> Source/WebCore/storage/StorageSyncManager.cpp:77 > + ASSERT(m_thread);
No "if (m_thread)" this time?
Anders Carlsson
Comment 4
2013-04-29 11:25:28 PDT
Committed
r149300
: <
http://trac.webkit.org/changeset/149300
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug