Bug 115359 - [BlackBerry] ImageBuffer::copyImage leaking memory
Summary: [BlackBerry] ImageBuffer::copyImage leaking memory
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Other
: P2 Normal
Assignee: Mike Lattanzio
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-29 08:39 PDT by Mike Lattanzio
Modified: 2013-04-30 08:00 PDT (History)
1 user (show)

See Also:

Attachments
Patch (2.56 KB, patch)
2013-04-29 08:44 PDT, Mike Lattanzio 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-cq-01 for mac-mountainlion (624.36 KB, application/zip)
2013-04-29 12:58 PDT, WebKit Commit Bot 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Lattanzio 2013-04-29 08:39:46 PDT 
We create a temporary buffer to give to the TiledImage expecting ownership to be transferred, but it is not.
Comment 1 Mike Lattanzio 2013-04-29 08:44:16 PDT 
Created attachment 200018 [details]
Patch
Comment 2 Konrad Piascik 2013-04-29 08:49:57 PDT 
Comment on attachment 200018 [details]
Patch

glad we're off the heap, lgtm
Comment 3 Jakob Petsovits 2013-04-29 08:52:59 PDT 
Comment on attachment 200018 [details]
Patch

Seconding Konrad, this is good and important.
Comment 4 WebKit Commit Bot 2013-04-29 12:58:13 PDT 
Comment on attachment 200018 [details]
Patch

Rejecting attachment 200018 [details] from commit-queue.

New failing tests:
svg/batik/text/smallFonts.svg
Full output: http://webkit-queues.appspot.com/results/243214
Comment 5 WebKit Commit Bot 2013-04-29 12:58:14 PDT 
Created attachment 200038 [details]
Archive of layout-test-results from webkit-cq-01 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: webkit-cq-01  Port: mac-mountainlion  Platform: Mac OS X 10.8.3
Comment 6 Konrad Piascik 2013-04-30 07:44:31 PDT 
Comment on attachment 200018 [details]
Patch

failure on tests not related
Comment 7 WebKit Commit Bot 2013-04-30 08:00:01 PDT 
Comment on attachment 200018 [details]
Patch

Clearing flags on attachment: 200018

Committed r149370: <http://trac.webkit.org/changeset/149370>
Comment 8 WebKit Commit Bot 2013-04-30 08:00:03 PDT 
All reviewed patches have been landed.  Closing bug.