Errors messages on Qt WK2 bots: In file included from /ramdisk/qt-linux-32-release-webkit2/build/Source/WebKit2/PluginProcess/WebProcessConnection.cpp:27:0: [1;31m/ramdisk/qt-linux-32-release-webkit2/build/Source/WebKit2/PluginProcess/WebProcessConnection.h:81:54: error: 'm_pluginControllers' was not declared in this scope[0m [1;31m/ramdisk/qt-linux-32-release-webkit2/build/Source/WebKit2/PluginProcess/WebProcessConnection.h:81:51: error: '>>' should be '> >' within a nested template argument list[0m /ramdisk/qt-linux-32-release-webkit2/build/Source/WebKit2/PluginProcess/WebProcessConnection.cpp: In member function 'virtual void WebKit::WebProcessConnection::didClose(CoreIPC::Connection*)': [1;31m/ramdisk/qt-linux-32-release-webkit2/build/Source/WebKit2/PluginProcess/WebProcessConnection.cpp:170:16: error: ISO C++ forbids declaration of 'pluginController' with no type [-fpermissive][0m [1;31m/ramdisk/qt-linux-32-release-webkit2/build/Source/WebKit2/PluginProcess/WebProcessConnection.cpp:170:34: error: range-based-for loops are not allowed in C++98 mode[0m [1;31m/ramdisk/qt-linux-32-release-webkit2/build/Source/WebKit2/PluginProcess/WebProcessConnection.cpp:171:51: error: request for member 'get' in 'pluginController', which is of non-class type 'int'[0m ICECC[15102] 11:18:35: Compiled on 10.6.11.18 make[3]: *** [.obj/release-shared/PluginProcess/WebProcessConnection.o] Error 1 make[3]: *** Waiting for unfinished jobs.... In file included from /ramdisk/qt-linux-32-release-webkit2/build/Source/WebKit2/PluginProcess/PluginProcess.cpp:38:0: [1;31m/ramdisk/qt-linux-32-release-webkit2/build/Source/WebKit2/PluginProcess/WebProcessConnection.h:81:54: error: 'm_pluginControllers' was not declared in this scope[0m [1;31m/ramdisk/qt-linux-32-release-webkit2/build/Source/WebKit2/PluginProcess/WebProcessConnection.h:81:51: error: '>>' should be '> >' within a nested template argument list[0m ICECC[15101] 11:18:35: Compiled on 10.6.11.10 make[3]: *** [.obj/release-shared/PluginProcess/PluginProcess.o] Error 1 In file included from /ramdisk/qt-linux-32-release-webkit2/build/Source/WebKit2/PluginProcess/PluginControllerProxy.cpp:42:0: [1;31m/ramdisk/qt-linux-32-release-webkit2/build/Source/WebKit2/PluginProcess/WebProcessConnection.h:81:54: error: 'm_pluginControllers' was not declared in this scope[0m [1;31m/ramdisk/qt-linux-32-release-webkit2/build/Source/WebKit2/PluginProcess/WebProcessConnection.h:81:51: error: '>>' should be '> >' within a nested template argument list[0m ICECC[15100] 11:18:36: Compiled on 10.109.212.1 make[3]: *** [.obj/release-shared/PluginProcess/PluginControllerProxy.o] Error 1 In file included from generated/WebProcessConnectionMessageReceiver.cpp:29:0: [1;31m/ramdisk/qt-linux-32-release-webkit2/build/Source/WebKit2/PluginProcess/WebProcessConnection.h:81:54: error: 'm_pluginControllers' was not declared in this scope[0m [1;31m/ramdisk/qt-linux-32-release-webkit2/build/Source/WebKit2/PluginProcess/WebProcessConnection.h:81:51: error: '>>' should be '> >' within a nested template argument list[0m After changing Source/WebKit2/PluginProcess/WebProcessConnection.h - HashMap<uint64_t, OwnPtr<PluginControllerProxy>> m_pluginControllers; + HashMap<uint64_t, OwnPtr<PluginControllerProxy> > m_pluginControllers; getting other error message: /home/azbest/webkit/WebKit/Source/WebKit2/PluginProcess/WebProcessConnection.cpp: In member function 'virtual void WebKit::WebProcessConnection::didClose(CoreIPC::Connection*)': /home/azbest/webkit/WebKit/Source/WebKit2/PluginProcess/WebProcessConnection.cpp:170:16: error: ISO C++ forbids declaration of 'pluginController' with no type [-fpermissive] /home/azbest/webkit/WebKit/Source/WebKit2/PluginProcess/WebProcessConnection.cpp:170:34: error: range-based-for loops are not allowed in C++98 mode /home/azbest/webkit/WebKit/Source/WebKit2/PluginProcess/WebProcessConnection.cpp:171:51: error: request for member 'get' in 'pluginController', which is of non-class type 'int'
Created attachment 199989 [details] c++0x Enabling c++0x on Qt WK2 is fixing the build, but I don't know if we want enable it or not.
Created attachment 200000 [details] patch: c++11 for Qt WK2 With CONFIG += c++11 Qt WebKit2 builds fine on linux and windows, too.
Comment on attachment 200000 [details] patch: c++11 for Qt WK2 Clearing flags on attachment: 200000 Committed r149291: <http://trac.webkit.org/changeset/149291>
All reviewed patches have been landed. Closing bug.