RESOLVED FIXED 115344
[WK2] Remove build warnings by -Wunused-parameter 
https://bugs.webkit.org/show_bug.cgi?id=115344
Summary [WK2] Remove build warnings by -Wunused-parameter
Jinwoo Song
Reported 2013-04-28 23:22:00 PDT
Fix build warnings occurred by -Wunused-parameter.
Attachments
Patch (3.03 KB, patch)
2013-04-28 23:30 PDT, Jinwoo Song 		andersca: review+
DetailsFormatted DiffDiff
patch for landing. (2.71 KB, patch)
2013-04-29 06:15 PDT, Jinwoo Song 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jinwoo Song
Comment 1 2013-04-28 23:30:17 PDT
Created attachment 199986 [details] Patch
Noam Rosenthal
Comment 2 2013-04-28 23:35:31 PDT
Comment on attachment 199986 [details] Patch LGTM, needs WK2 owner.
Anders Carlsson
Comment 3 2013-04-29 06:02:18 PDT
Comment on attachment 199986 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=199986&action=review > Source/WebKit2/UIProcess/DrawingAreaProxy.h:71 > + virtual void waitForPossibleGeometryUpdate(double timeout = didUpdateBackingStoreStateTimeout) { UNUSED_PARAM(timeout); } This can just be virtual void waitForPossibleGeometryUpdate(double = didUpdateBackingStoreStateTimeout) { }
Jinwoo Song
Comment 4 2013-04-29 06:15:28 PDT
Created attachment 199997 [details] patch for landing. Applied Anders's comment.
WebKit Commit Bot
Comment 5 2013-04-29 06:27:28 PDT
Comment on attachment 199997 [details] patch for landing. Rejecting attachment 199997 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'validate-changelog', '--non-interactive', 199997, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit /Volumes/Data/EWS/WebKit/Source/WebKit2/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://webkit-queues.appspot.com/results/195674
WebKit Commit Bot
Comment 6 2013-04-29 07:15:23 PDT
Comment on attachment 199997 [details] patch for landing. Clearing flags on attachment: 199997 Committed r149279: <http://trac.webkit.org/changeset/149279>
WebKit Commit Bot
Comment 7 2013-04-29 07:15:25 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.