Bug 115344 - [WK2] Remove build warnings by -Wunused-parameter
Summary: [WK2] Remove build warnings by -Wunused-parameter
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jinwoo Song
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-28 23:22 PDT by Jinwoo Song
Modified: 2013-04-29 07:15 PDT (History)
5 users (show)

See Also:


Attachments
Patch (3.03 KB, patch)
2013-04-28 23:30 PDT, Jinwoo Song
andersca: review+
Details | Formatted Diff | Diff
patch for landing. (2.71 KB, patch)
2013-04-29 06:15 PDT, Jinwoo Song
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jinwoo Song 2013-04-28 23:22:00 PDT
Fix build warnings occurred by -Wunused-parameter.
Comment 1 Jinwoo Song 2013-04-28 23:30:17 PDT
Created attachment 199986 [details]
Patch
Comment 2 Noam Rosenthal 2013-04-28 23:35:31 PDT
Comment on attachment 199986 [details]
Patch

LGTM, needs WK2 owner.
Comment 3 Anders Carlsson 2013-04-29 06:02:18 PDT
Comment on attachment 199986 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=199986&action=review

> Source/WebKit2/UIProcess/DrawingAreaProxy.h:71
> +    virtual void waitForPossibleGeometryUpdate(double timeout = didUpdateBackingStoreStateTimeout) { UNUSED_PARAM(timeout); }

This can just be 

virtual void waitForPossibleGeometryUpdate(double = didUpdateBackingStoreStateTimeout) { }
Comment 4 Jinwoo Song 2013-04-29 06:15:28 PDT
Created attachment 199997 [details]
patch for landing.

Applied Anders's comment.
Comment 5 WebKit Commit Bot 2013-04-29 06:27:28 PDT
Comment on attachment 199997 [details]
patch for landing.

Rejecting attachment 199997 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'validate-changelog', '--non-interactive', 199997, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

/Volumes/Data/EWS/WebKit/Source/WebKit2/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://webkit-queues.appspot.com/results/195674
Comment 6 WebKit Commit Bot 2013-04-29 07:15:23 PDT
Comment on attachment 199997 [details]
patch for landing.

Clearing flags on attachment: 199997

Committed r149279: <http://trac.webkit.org/changeset/149279>
Comment 7 WebKit Commit Bot 2013-04-29 07:15:25 PDT
All reviewed patches have been landed.  Closing bug.